feat(specimens): link the repository from the site header - #12
Merged
Merged
Conversation
Add a GitHub link next to search and the scheme toggle, matching spell-ui's header. It is a plain anchor styled with buttonVariants so it stays a link to assistive tech, opens in a new tab with rel="noopener noreferrer", and shares the scheme control's sizing: 36px on desktop, 44px under 68rem and on coarse pointers. lucide-react 1.x ships no brand marks, so the GitHub mark is inlined. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
5 tasks
Contributor
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The only noted issue is a non-blocking test-coverage nit.
Review effort: Lite
Findings: 1
Open (1)
What changed in this PR
Adds an accessible GitHub repository link beside the search and theme controls in the specimens site header.
Changes:
- Adds an external GitHub anchor with secure new-tab handling.
- Adds an inline GitHub icon and accessible label.
- Styles the repository control responsively.
| File | Description |
|---|---|
apps/specimens/src/specimens.css |
Styles the repository control across breakpoints. |
apps/specimens/src/app.tsx |
Adds the GitHub repository link and icon. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+816
to
+828
| <a | ||
| href={repository} | ||
| target="_blank" | ||
| rel="noopener noreferrer" | ||
| className={cn( | ||
| buttonVariants({ variant: "ghost" }), | ||
| "repository-control", | ||
| )} | ||
| aria-label="OpenCoven UI on GitHub" | ||
| title="OpenCoven UI on GitHub" | ||
| > | ||
| <GitHubMark /> | ||
| </a> |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This adds a GitHub link to the site header, next to search and the scheme toggle, where spell-ui puts it.
A side-by-side comparison with spell-ui found that main already delivers its docs layout:
/. That was deliberate, so this PR keeps it.The header's missing repository link was the only gap the reviews allowed us to close. spell-ui's marketing homepage stays out of scope because it would displace the catalog at
/.Change
<a>styled with the exportedbuttonVariants({ variant: "ghost" }). It is an anchor rather than a Base UIButtonwithrender, which would addrole="button"and announce the link as a button.href="https://github.com/OpenCoven/ui"(the existingrepositoryconstant),target="_blank",rel="noopener noreferrer",aria-label="OpenCoven UI on GitHub"..repository-controlclass shares the scheme toggle's sizing: 36px on desktop, 44px under 68rem and on coarse pointers. It keeps its own class name so review scripts that target.scheme-controlstill find the theme toggle.currentColorSVG markedaria-hidden.Verification
pnpm format:check && pnpm lint && pnpm typecheck && pnpm testall pass (54/54 tests).scripts/visual-review.mjsagainstvite preview: 25/25 scenarios passing.scripts/mobile-quality-review.mjs: 9/9 passing, withdocumentOverflow0 in every scenario, including 320px, 320px at 200% text, and 390px RTL.A direct probe of the new link:
No review check was edited or skipped.
🤖 Generated with Claude Code