Skip to content

Fix SFSymbols build and link issue#811

Merged
Kyle-Ye merged 2 commits intomainfrom
feature/sf
Mar 8, 2026
Merged

Fix SFSymbols build and link issue#811
Kyle-Ye merged 2 commits intomainfrom
feature/sf

Conversation

@Kyle-Ye
Copy link
Collaborator

@Kyle-Ye Kyle-Ye commented Mar 8, 2026

No description provided.

@github-actions github-actions bot added bug Something isn't working build issue labels Mar 8, 2026
@augmentcode
Copy link

augmentcode bot commented Mar 8, 2026

🤖 Augment PR Summary

Summary: Fixes the Example Xcode build/link by adding SFSymbols.xcframework to the project and linking it into the app targets.

Changes: Conditionally imports SFSymbols in NamedImage.swift when OPENSWIFTUI_LINK_SFSYMBOLS is enabled so symbol lookup code compiles and links correctly.

🤖 Was this summary useful? React with 👍 or 👎

Copy link

@augmentcode augmentcode bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review completed. No suggestions at this time.

Comment augment review to trigger a new review at any time.

@codecov
Copy link

codecov bot commented Mar 8, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 13.99%. Comparing base (6945325) to head (f0cb1db).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #811      +/-   ##
==========================================
- Coverage   13.99%   13.99%   -0.01%     
==========================================
  Files         624      624              
  Lines       37809    37809              
==========================================
- Hits         5291     5290       -1     
- Misses      32518    32519       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Kyle-Ye Kyle-Ye merged commit 41ccc0f into main Mar 8, 2026
6 of 8 checks passed
@Kyle-Ye Kyle-Ye deleted the feature/sf branch March 8, 2026 07:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant