Skip to content

Fix SFSymbols build and link issue #811

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Kyle-Ye merged 2 commits into from
Mar 8, 2026
Merged

Fix SFSymbols build and link issue #811

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4cbc042
Fix SFSymbols import issue
Kyle-Ye Mar 8, 2026
f0cb1db
Add SFSymbols linking in pb file
Kyle-Ye Mar 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions Example/Example.xcodeproj/project.pbxproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,10 @@
27AF22BD2E758F3700D534AB /* RenderBox.xcframework in Frameworks */ = {isa = PBXBuildFile; fileRef = 27E6C4D42D2842810010502F /* RenderBox.xcframework */; };
27CD0B5F2AFC8DA7003665EB /* OpenSwiftUI in Frameworks */ = {isa = PBXBuildFile; productRef = 27CD0B5E2AFC8DA7003665EB /* OpenSwiftUI */; };
27D49E0E2BA60AF600F6E2E2 /* OpenSwiftUI in Frameworks */ = {isa = PBXBuildFile; productRef = 27D49E0D2BA60AF600F6E2E2 /* OpenSwiftUI */; };
27E28F0B2F5D5531007F8CF5 /* SFSymbols.xcframework in Frameworks */ = {isa = PBXBuildFile; fileRef = 27E28F0A2F5D5531007F8CF5 /* SFSymbols.xcframework */; };
27E28F0E2F5D553F007F8CF5 /* SFSymbols.xcframework in Frameworks */ = {isa = PBXBuildFile; fileRef = 27E28F0A2F5D5531007F8CF5 /* SFSymbols.xcframework */; };
27E28F112F5D5547007F8CF5 /* SFSymbols.xcframework in Frameworks */ = {isa = PBXBuildFile; fileRef = 27E28F0A2F5D5531007F8CF5 /* SFSymbols.xcframework */; };
27E28F142F5D5556007F8CF5 /* SFSymbols.xcframework in Frameworks */ = {isa = PBXBuildFile; fileRef = 27E28F0A2F5D5531007F8CF5 /* SFSymbols.xcframework */; };
27E6C4D32D2842740010502F /* AttributeGraph.xcframework in Frameworks */ = {isa = PBXBuildFile; fileRef = 27E6C4D12D2842740010502F /* AttributeGraph.xcframework */; };
/* End PBXBuildFile section */

Expand Down Expand Up @@ -58,6 +62,7 @@
27CD0B492AFC8D37003665EB /* Example.app */ = {isa = PBXFileReference; explicitFileType = wrapper.application; includeInIndex = 0; path = Example.app; sourceTree = BUILT_PRODUCTS_DIR; };
27CD0B612AFC8E0E003665EB /* OpenSwiftUI */ = {isa = PBXFileReference; lastKnownFileType = wrapper; name = OpenSwiftUI; path = ..; sourceTree = "<group>"; };
27D49DF82BA604FB00F6E2E2 /* HostingExample.app */ = {isa = PBXFileReference; explicitFileType = wrapper.application; includeInIndex = 0; path = HostingExample.app; sourceTree = BUILT_PRODUCTS_DIR; };
27E28F0A2F5D5531007F8CF5 /* SFSymbols.xcframework */ = {isa = PBXFileReference; lastKnownFileType = wrapper.xcframework; name = SFSymbols.xcframework; path = ../../DarwinPrivateFrameworks/SF/2024/SFSymbols.xcframework; sourceTree = "<group>"; };
27E6C4D02D2842530010502F /* OpenRenderBox */ = {isa = PBXFileReference; lastKnownFileType = wrapper; name = OpenRenderBox; path = ../../OpenRenderBox; sourceTree = "<group>"; };
27E6C4D12D2842740010502F /* AttributeGraph.xcframework */ = {isa = PBXFileReference; lastKnownFileType = wrapper.xcframework; name = AttributeGraph.xcframework; path = ../../DarwinPrivateFrameworks/AG/2024/AttributeGraph.xcframework; sourceTree = "<group>"; };
27E6C4D42D2842810010502F /* RenderBox.xcframework */ = {isa = PBXFileReference; lastKnownFileType = wrapper.xcframework; name = RenderBox.xcframework; path = ../../DarwinPrivateFrameworks/RB/2024/RenderBox.xcframework; sourceTree = "<group>"; };
Expand Down Expand Up @@ -112,6 +117,7 @@
files = (
279FED0D2DF4567B00320390 /* OpenSwiftUI in Frameworks */,
27AF22B82E758F2E00D534AB /* BacklightServices.xcframework in Frameworks */,
27E28F112F5D5547007F8CF5 /* SFSymbols.xcframework in Frameworks */,
27AF22B42E758F2900D534AB /* CoreUI.xcframework in Frameworks */,
27AF22BC2E758F3700D534AB /* RenderBox.xcframework in Frameworks */,
279FED052DF4566D00320390 /* AttributeGraph.xcframework in Frameworks */,
Expand All @@ -124,6 +130,7 @@
files = (
2792849F2DFF137400234D64 /* SnapshotTesting in Frameworks */,
27AF22B92E758F2E00D534AB /* BacklightServices.xcframework in Frameworks */,
27E28F142F5D5556007F8CF5 /* SFSymbols.xcframework in Frameworks */,
27AF22B52E758F2900D534AB /* CoreUI.xcframework in Frameworks */,
27AF22BD2E758F3700D534AB /* RenderBox.xcframework in Frameworks */,
279284972DFF136E00234D64 /* AttributeGraph.xcframework in Frameworks */,
Expand All @@ -136,6 +143,7 @@
files = (
27AF22B22E758F2900D534AB /* CoreUI.xcframework in Frameworks */,
27AF22B62E758F2E00D534AB /* BacklightServices.xcframework in Frameworks */,
27E28F0B2F5D5531007F8CF5 /* SFSymbols.xcframework in Frameworks */,
27CD0B5F2AFC8DA7003665EB /* OpenSwiftUI in Frameworks */,
278EF52F2E227304009C32EB /* Equatable in Frameworks */,
27E6C4D32D2842740010502F /* AttributeGraph.xcframework in Frameworks */,
Expand All @@ -149,6 +157,7 @@
files = (
27AF22B32E758F2900D534AB /* CoreUI.xcframework in Frameworks */,
27AF22B72E758F2E00D534AB /* BacklightServices.xcframework in Frameworks */,
27E28F0E2F5D553F007F8CF5 /* SFSymbols.xcframework in Frameworks */,
27D49E0E2BA60AF600F6E2E2 /* OpenSwiftUI in Frameworks */,
278EF52D2E2272F2009C32EB /* Equatable in Frameworks */,
27186AE32D538A76009E05F9 /* AttributeGraph.xcframework in Frameworks */,
Expand Down Expand Up @@ -193,6 +202,7 @@
27D49E0C2BA60AF600F6E2E2 /* Frameworks */ = {
isa = PBXGroup;
children = (
27E28F0A2F5D5531007F8CF5 /* SFSymbols.xcframework */,
279080912E8E5E7B0082B5B6 /* Testing.framework */,
27AF22B12E758F0F00D534AB /* BacklightServices.xcframework */,
27EE91722DD0C753006C85FD /* CoreUI.xcframework */,
Expand Down
3 changes: 3 additions & 0 deletions Sources/OpenSwiftUICore/View/Image/NamedImage.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,9 @@ import CoreGraphics_Private
package import CoreUI
import GraphicsServices_Private
#endif
#if OPENSWIFTUI_LINK_SFSYMBOLS
import SFSymbols
#endif

// MARK: - NamedImage

Expand Down
3 changes: 3 additions & 0 deletions Tests/OpenSwiftUICoreTests/Util/SFSymbolsShimsTests.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,9 @@
#if canImport(Darwin)
import OpenSwiftUICore
import Testing
#if OPENSWIFTUI_LINK_SFSYMBOLS
import SFSymbols
#endif

struct SFSymbolsShimsTests {
@Test
Expand Down
Loading