[NFC] Use RB for properties and function and ORB for type#821
Conversation
🤖 Augment PR SummarySummary: This PR performs an NFC terminology cleanup to consistently use Changes:
Technical Notes: This is primarily a naming alignment pass; underlying ORB/RB types and behavior are unchanged, but some public-facing identifiers may be impacted. 🤖 Was this summary useful? React with 👍 or 👎 |
| case displayList(DisplayList, CGPoint, Time) | ||
| case orbDisplayList(any ORBDisplayListContents, CGPoint) | ||
| case orbInterpolator(ORBDisplayListInterpolator, Float, CGPoint) | ||
| case rbDisplayList(any ORBDisplayListContents, CGPoint) |
There was a problem hiding this comment.
PlatformDrawableContent.Contents appears to be part of the public surface here, and renaming enum cases (orbDisplayList → rbDisplayList, orbInterpolator → rbInterpolator) is a source-breaking change for downstream callers. If the intent is NFC, consider keeping the old case names as deprecated shims to preserve compatibility.
Severity: medium
🤖 Was this useful? React with 👍 or 👎, or 🚀 if it prevented an incident/outage.
| @@ -45,7 +45,7 @@ public struct _RendererConfiguration { | |||
|
|
|||
| /// When non-nil overrides colorMode with a member of the | |||
| /// `RBColorMode` enum, specified as its raw integer value. | |||
There was a problem hiding this comment.
_RendererConfiguration.Options.rbColorMode was renamed from orbColorMode; if this type/property is public API, this is source-breaking for clients upgrading. If the rename is intentional, consider providing a deprecated alias to ease migration.
Severity: medium
🤖 Was this useful? React with 👍 or 👎, or 🚀 if it prevented an incident/outage.
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #821 +/- ##
==========================================
- Coverage 27.49% 27.47% -0.02%
==========================================
Files 661 661
Lines 42444 42444
==========================================
- Hits 11670 11662 -8
- Misses 30774 30782 +8 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
No description provided.