Skip to content

[NFC] Use RB for properties and function and ORB for type#821

Merged
Kyle-Ye merged 1 commit intomainfrom
k-branch-1
Mar 10, 2026
Merged

[NFC] Use RB for properties and function and ORB for type#821
Kyle-Ye merged 1 commit intomainfrom
k-branch-1

Conversation

@Kyle-Ye
Copy link
Collaborator

@Kyle-Ye Kyle-Ye commented Mar 10, 2026

No description provided.

@Kyle-Ye Kyle-Ye requested a review from Mx-Iris as a code owner March 10, 2026 18:00
@Kyle-Ye Kyle-Ye merged commit 410618c into main Mar 10, 2026
8 checks passed
@Kyle-Ye Kyle-Ye deleted the k-branch-1 branch March 10, 2026 18:00
@augmentcode
Copy link

augmentcode bot commented Mar 10, 2026

🤖 Augment PR Summary

Summary: This PR performs an NFC terminology cleanup to consistently use rb for properties/locals/functions while keeping ORB* for the underlying RenderBox types.

Changes:

  • Renamed various locals and helper initializers (e.g., orbInitrbInit, orbLayerrbLayer) in display list view/layer setup
  • Updated option propagation APIs to use rbLayer parameter naming
  • Adjusted rasterization/color-mode naming (orbColorModerbColorMode) and protobuf encoding fields accordingly
  • Renamed internal path storage kind/accessors from orbPath to rbPath
  • Renamed symbol rendering mode helpers (orbRenderingModerbRenderingMode) and related call sites

Technical Notes: This is primarily a naming alignment pass; underlying ORB/RB types and behavior are unchanged, but some public-facing identifiers may be impacted.

🤖 Was this summary useful? React with 👍 or 👎

Copy link

@augmentcode augmentcode bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review completed. 2 suggestions posted.

Fix All in Augment

Comment augment review to trigger a new review at any time.

case displayList(DisplayList, CGPoint, Time)
case orbDisplayList(any ORBDisplayListContents, CGPoint)
case orbInterpolator(ORBDisplayListInterpolator, Float, CGPoint)
case rbDisplayList(any ORBDisplayListContents, CGPoint)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PlatformDrawableContent.Contents appears to be part of the public surface here, and renaming enum cases (orbDisplayListrbDisplayList, orbInterpolatorrbInterpolator) is a source-breaking change for downstream callers. If the intent is NFC, consider keeping the old case names as deprecated shims to preserve compatibility.

Severity: medium

Fix This in Augment

🤖 Was this useful? React with 👍 or 👎, or 🚀 if it prevented an incident/outage.

@@ -45,7 +45,7 @@ public struct _RendererConfiguration {

/// When non-nil overrides colorMode with a member of the
/// `RBColorMode` enum, specified as its raw integer value.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

_RendererConfiguration.Options.rbColorMode was renamed from orbColorMode; if this type/property is public API, this is source-breaking for clients upgrading. If the rename is intentional, consider providing a deprecated alias to ease migration.

Severity: medium

Fix This in Augment

🤖 Was this useful? React with 👍 or 👎, or 🚀 if it prevented an incident/outage.

@codecov
Copy link

codecov bot commented Mar 10, 2026

Codecov Report

❌ Patch coverage is 0% with 42 lines in your changes missing coverage. Please review.
✅ Project coverage is 27.47%. Comparing base (9e06f2d) to head (0594bbf).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
Sources/OpenSwiftUICore/Shape/Path.swift 0.00% 16 Missing ⚠️
...ces/OpenSwiftUICore/View/Image/GraphicsImage.swift 0.00% 7 Missing ⚠️
.../OpenSwiftUICore/Render/RasterizationOptions.swift 0.00% 5 Missing ⚠️
...OpenSwiftUI/Render/DisplayList/RenderBoxView.swift 0.00% 3 Missing ⚠️
...SwiftUI/Render/DisplayList/AppKitDisplayList.swift 0.00% 2 Missing ⚠️
...rces/OpenSwiftUICore/Render/PlatformDrawable.swift 0.00% 2 Missing ⚠️
Sources/OpenSwiftUICore/Shape/PathData.swift 0.00% 2 Missing ⚠️
...enSwiftUICore/View/Image/SymbolRenderingMode.swift 0.00% 2 Missing ⚠️
...UI/Render/DisplayList/DisplayListViewDrawing.swift 0.00% 1 Missing ⚠️
...DisplayList/CAHostingLayerPlatformDefinition.swift 0.00% 1 Missing ⚠️
... and 1 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #821      +/-   ##
==========================================
- Coverage   27.49%   27.47%   -0.02%     
==========================================
  Files         661      661              
  Lines       42444    42444              
==========================================
- Hits        11670    11662       -8     
- Misses      30774    30782       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant