Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -90,8 +90,8 @@ final class NSViewPlatformViewDefinition: PlatformViewDefinition, @unchecked Sen
}

override static func getRBLayer(drawingView: AnyObject) -> AnyObject? {
guard let orbView = drawingView as? ORBDrawingView else { return nil }
return orbView.layer
guard let rbView = drawingView as? ORBDrawingView else { return nil }
return rbView.layer
}

override static func setIgnoresEvents(_ state: Bool, of view: AnyObject) {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -152,9 +152,9 @@ final class ORBDrawingView: OpenRenderBoxView, PlatformDrawable {
private func updateOptions() {
isOpaque = options.isOpaque
#if os(iOS) || os(visionOS)
options.update(orbLayer: layer)
options.update(rbLayer: layer)
#elseif os(macOS)
options.update(orbLayer: layer!)
options.update(rbLayer: layer!)
#endif
rendersFirstFrameAsynchronously = options.rendersFirstFrameAsynchronously
}
Expand Down
6 changes: 3 additions & 3 deletions Sources/OpenSwiftUI/Render/DisplayList/RenderBoxView.swift
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ class OpenRenderBoxView: PlatformGraphicsView {
}
#endif

private func orbInit() {
private func rbInit() {
#if os(iOS) || os(visionOS)
let layer = layer
layer.delegate = self
Expand All @@ -43,13 +43,13 @@ class OpenRenderBoxView: PlatformGraphicsView {
override init(frame: CGRect) {
rendersFirstFrameAsynchronously = false
super.init(frame: frame)
orbInit()
rbInit()
}

required init?(coder: NSCoder) {
rendersFirstFrameAsynchronously = false
super.init(coder: coder)
orbInit()
rbInit()
}

deinit {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -75,8 +75,8 @@ final class UIViewPlatformViewDefinition: PlatformViewDefinition, @unchecked Sen
}

override static func getRBLayer(drawingView: AnyObject) -> AnyObject? {
guard let orbView = drawingView as? ORBDrawingView else { return nil }
return orbView.layer
guard let rbView = drawingView as? ORBDrawingView else { return nil }
return rbView.layer
}

override static func setIgnoresEvents(_ state: Bool, of view: AnyObject) {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -191,7 +191,7 @@ private final class ORBDrawingLayer: ORBLayer, PlatformDrawable {

private func updateOptions() {
isOpaque = options.isOpaque
options.update(orbLayer: self)
options.update(rbLayer: self)
}

static var allowsContentsMultiplyColor: Bool { false }
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -497,7 +497,7 @@ extension DisplayList {
private struct Contents {
var list: DisplayList
var origin: CGPoint
var orbList: ORBDisplayListContents
var rbList: ORBDisplayListContents
var nextTime: Time
var numericValue: Float?
}
Expand Down
8 changes: 4 additions & 4 deletions Sources/OpenSwiftUICore/Render/PlatformDrawable.swift
Original file line number Diff line number Diff line change
Expand Up @@ -45,8 +45,8 @@ public struct PlatformDrawableContent: @unchecked Sendable {
case graphicsCallback((inout GraphicsContext, CGSize) -> ())
case platformCallback((CGSize) -> ())
case displayList(DisplayList, CGPoint, Time)
case orbDisplayList(any ORBDisplayListContents, CGPoint)
case orbInterpolator(ORBDisplayListInterpolator, Float, CGPoint)
case rbDisplayList(any ORBDisplayListContents, CGPoint)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PlatformDrawableContent.Contents appears to be part of the public surface here, and renaming enum cases (orbDisplayListrbDisplayList, orbInterpolatorrbInterpolator) is a source-breaking change for downstream callers. If the intent is NFC, consider keeping the old case names as deprecated shims to preserve compatibility.

Severity: medium

Fix This in Augment

🤖 Was this useful? React with 👍 or 👎, or 🚀 if it prevented an incident/outage.

case rbInterpolator(ORBDisplayListInterpolator, Float, CGPoint)
case empty
}

Expand Down Expand Up @@ -141,9 +141,9 @@ public struct PlatformDrawableOptions: Equatable, Sendable {
}
#endif

public func update(orbLayer: AnyObject) {
public func update(rbLayer: AnyObject) {
#if canImport(Darwin)
let layer = orbLayer as! ORBLayer
let layer = rbLayer as! ORBLayer
layer.colorMode = base.resolvedColorMode
layer.rendersAsynchronously = rendersAsynchronously
layer.maxDrawableCount = Int(base.maxDrawableCount)
Expand Down
14 changes: 7 additions & 7 deletions Sources/OpenSwiftUICore/Render/RasterizationOptions.swift
Original file line number Diff line number Diff line change
Expand Up @@ -88,20 +88,20 @@ package struct RasterizationOptions: Equatable {

package var colorMode: ColorRenderingMode

package var orbColorMode: Int32?
package var rbColorMode: Int32?

package var flags: RasterizationOptions.Flags

package var maxDrawableCount: Int8

package init(
colorMode: ColorRenderingMode = .nonLinear,
orbColorMode: Int32? = nil,
rbColorMode: Int32? = nil,
flags: RasterizationOptions.Flags = .defaultFlags,
maxDrawableCount: Int8 = 3
) {
self.colorMode = colorMode
self.orbColorMode = orbColorMode
self.rbColorMode = rbColorMode
self.flags = flags
self.maxDrawableCount = maxDrawableCount
}
Expand Down Expand Up @@ -138,7 +138,7 @@ package struct RasterizationOptions: Equatable {

#if !OPENSWIFTUI_ANY_ATTRIBUTE_FIX
package var resolvedColorMode: ORBColor.Mode {
if let mode = orbColorMode {
if let mode = rbColorMode {
return ORBColor.Mode(rawValue: mode)
} else {
let alphaOnly = alphaOnly
Expand Down Expand Up @@ -176,8 +176,8 @@ package struct RasterizationOptions: Equatable {
extension RasterizationOptions: ProtobufMessage {
package func encode(to encoder: inout ProtobufEncoder) {
encoder.enumField(1, colorMode, defaultValue: .nonLinear)
if let orbColorMode {
encoder.intField(2, Int(orbColorMode))
if let rbColorMode {
encoder.intField(2, Int(rbColorMode))
}
encoder.intField(3, Int(flags.rawValue))
encoder.intField(4, Int(maxDrawableCount))
Expand All @@ -188,7 +188,7 @@ extension RasterizationOptions: ProtobufMessage {
while let field = try decoder.nextField() {
switch field.tag {
case 1: options.colorMode = try decoder.enumField(field) ?? .nonLinear
case 2: options.orbColorMode = Int32(try decoder.intField(field))
case 2: options.rbColorMode = Int32(try decoder.intField(field))
case 3: options.flags = Flags(rawValue: UInt32(try decoder.intField(field)))
case 4: options.maxDrawableCount = Int8(try decoder.intField(field))
default: try decoder.skipField(field)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ public struct _RendererConfiguration {

/// When non-nil overrides colorMode with a member of the
/// `RBColorMode` enum, specified as its raw integer value.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

_RendererConfiguration.Options.rbColorMode was renamed from orbColorMode; if this type/property is public API, this is source-breaking for clients upgrading. If the rename is intentional, consider providing a deprecated alias to ease migration.

Severity: medium

Fix This in Augment

🤖 Was this useful? React with 👍 or 👎, or 🚀 if it prevented an incident/outage.

public var orbColorMode: Int32?
public var rbColorMode: Int32?

/// When true the view will build and submit its command buffer
/// asynchronously.
Expand Down
34 changes: 17 additions & 17 deletions Sources/OpenSwiftUICore/Shape/Path.swift
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ public struct Path: Equatable, LosslessStringConvertible, @unchecked Sendable {
#if canImport(CoreGraphics) || !OPENSWIFTUI_CF_CGTYPES
case cgPath
#endif
case orbPath
case rbPath
case buffer
}

Expand All @@ -43,8 +43,8 @@ public struct Path: Equatable, LosslessStringConvertible, @unchecked Sendable {
#endif

package init(takingPath path: ORBPath) {
kind = .orbPath
data = PathData(orbPath: path)
kind = .rbPath
data = PathData(rbPath: path)
}

private func prepareBuffer() {
Expand All @@ -54,8 +54,8 @@ public struct Path: Equatable, LosslessStringConvertible, @unchecked Sendable {
case .cgPath:
path = ORBPath(cgPath: data.cgPath.takeRetainedValue())
#endif
case .orbPath:
path = data.orbPath
case .rbPath:
path = data.rbPath
case .buffer:
return
}
Expand Down Expand Up @@ -135,27 +135,27 @@ public struct Path: Equatable, LosslessStringConvertible, @unchecked Sendable {
#if canImport(CoreGraphics) || !OPENSWIFTUI_CF_CGTYPES
@inline(__always)
fileprivate var cgPath: CGPath {
let orbPath: ORBPath
let rbPath: ORBPath
switch kind {
case .cgPath:
return data.cgPath.takeUnretainedValue()
case .orbPath:
orbPath = data.orbPath
case .rbPath:
rbPath = data.rbPath
case .buffer:
let storage = unsafeBitCast(self, to: ORBPath.Storage.self)
orbPath = ORBPath(storage: storage, callbacks: Self.bufferCallbacks)
rbPath = ORBPath(storage: storage, callbacks: Self.bufferCallbacks)
}
return orbPath.cgPath
return rbPath.cgPath
}
#endif

@inline(__always)
fileprivate var orbPath: ORBPath {
fileprivate var rbPath: ORBPath {
switch kind {
case .cgPath:
return ORBPath(cgPath: data.cgPath.takeUnretainedValue())
case .orbPath:
return data.orbPath
case .rbPath:
return data.rbPath
case .buffer:
let storage = unsafeBitCast(self, to: ORBPath.Storage.self)
return ORBPath(storage: storage, callbacks: Self.bufferCallbacks)
Expand All @@ -164,14 +164,14 @@ public struct Path: Equatable, LosslessStringConvertible, @unchecked Sendable {

@inline(__always)
fileprivate func retainRBPath() -> ORBPath {
let orbPath = orbPath
orbPath.retain()
return orbPath
let rbPath = rbPath
rbPath.retain()
return rbPath
}

@usableFromInline
package static func == (lhs: PathBox, rhs: PathBox) -> Bool {
return lhs.orbPath.isEqual(to: rhs.orbPath)
return lhs.rbPath.isEqual(to: rhs.rbPath)
}
}

Expand Down
8 changes: 4 additions & 4 deletions Sources/OpenSwiftUICore/Shape/PathData.swift
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ package import OpenRenderBoxShims
///
/// typedef union PathData {
/// CGPathRef cgPath; // 8 bytes (pointer)
/// ORBPath orbPath; // 16 bytes (2 pointers)
/// ORBPath rbPath; // 16 bytes (2 pointers)
/// uint8_t buffer[0x60]; // 96 bytes
/// } PathData;
package struct PathData {
Expand Down Expand Up @@ -74,11 +74,11 @@ package struct PathData {

// MARK: - ORBPath access

package init(orbPath: ORBPath) {
self.orbPath = orbPath
package init(rbPath: ORBPath) {
self.rbPath = rbPath
}

package var orbPath: ORBPath {
package var rbPath: ORBPath {
get {
withUnsafeBytes(of: storage) { buffer in
buffer.load(as: ORBPath.self)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ package struct _ShapeStyle_ResolverMode: Equatable {
self.options = options
}

package init(orbSymbolStyleMask mask: UInt32, location: Image.Location) {
package init(rbSymbolStyleMask mask: UInt32, location: Image.Location) {
let bundle: Bundle?
var options: Options
if mask & (1 << 9) != 0 {
Expand Down
14 changes: 7 additions & 7 deletions Sources/OpenSwiftUICore/View/Image/GraphicsImage.swift
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,7 @@ package struct GraphicsImage: Equatable, Sendable {
switch contents {
case let .vectorGlyph(resolvedVectorGlyph):
return .init(
orbSymbolStyleMask: resolvedVectorGlyph.animator.styleMask,
rbSymbolStyleMask: resolvedVectorGlyph.animator.styleMask,
location: resolvedVectorGlyph.location
)
case .none:
Expand Down Expand Up @@ -199,7 +199,7 @@ package struct ResolvedVectorGlyph: Equatable {
animator.glyph = glyph
animator.variableValue = variableValue
animator.flipsRightToLeft = flipsRightToLeft
animator.renderingMode = context.effectiveSymbolRenderingMode?.orbRenderingMode ?? 255
animator.renderingMode = context.effectiveSymbolRenderingMode?.rbRenderingMode ?? 255
let direction = context.environment.layoutDirection
let version = animator.version
let options = context.options
Expand Down Expand Up @@ -231,14 +231,14 @@ package struct ResolvedVectorGlyph: Equatable {
}

package var renderingMode: SymbolRenderingMode.Storage? {
SymbolRenderingMode(orbRenderingMode: animator.renderingMode)?.storage
SymbolRenderingMode(rbRenderingMode: animator.renderingMode)?.storage
}

package var resolvedRenderingMode: SymbolRenderingMode.Storage? {
#if OPENSWIFTUI_LINK_COREUI && OPENSWIFTUI_RENDERBOX
let orbMode = animator.renderingMode
guard orbMode == 0 else {
return SymbolRenderingMode(orbRenderingMode: orbMode)?.storage
let rbMode = animator.renderingMode
guard rbMode == 0 else {
return SymbolRenderingMode(rbRenderingMode: rbMode)?.storage
}
guard let glyph = animator.glyph else {
return .preferred
Expand All @@ -258,7 +258,7 @@ package struct ResolvedVectorGlyph: Equatable {
}

package var styleResolverMode: ShapeStyle.ResolverMode {
.init(orbSymbolStyleMask: animator.styleMask, location: location)
.init(rbSymbolStyleMask: animator.styleMask, location: location)
}

// MARK: - Methods
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -101,7 +101,7 @@ public struct SymbolRenderingMode: Sendable {
// MARK: - SymbolRenderingMode + RB Rendering Mode

extension SymbolRenderingMode {
package var orbRenderingMode: UInt32 {
package var rbRenderingMode: UInt32 {
switch storage {
case .monochrome: 1
case .multicolor: 2
Expand All @@ -114,7 +114,7 @@ extension SymbolRenderingMode {
}
}

package init?(orbRenderingMode mode: UInt32) {
package init?(rbRenderingMode mode: UInt32) {
switch mode {
case 0: self = .preferred
case 1: self = .monochrome
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -234,9 +234,9 @@ CGPathRef _CGPathCreateRoundedRect(CGRect rect, CGFloat cornerWidth, CGFloat cor
RBPathRelease(rbPath);
return cgPath;
#else
ORBPath orbPath = ORBPathMakeRoundedRect(rect, cornerWidth, cornerHeight, ORBPathRoundedCornerStyleContinuous, NULL);
CGPathRef cgPath = ORBPathCopyCGPath(orbPath);
ORBPathRelease(orbPath);
ORBPath rbPath = ORBPathMakeRoundedRect(rect, cornerWidth, cornerHeight, ORBPathRoundedCornerStyleContinuous, NULL);
CGPathRef cgPath = ORBPathCopyCGPath(rbPath);
ORBPathRelease(rbPath);
return cgPath;
#endif
}
Expand Down
4 changes: 2 additions & 2 deletions Sources/OpenSwiftUI_SPI/Util/PathData.h
Original file line number Diff line number Diff line change
Expand Up @@ -28,9 +28,9 @@ typedef union PathData {
CGPathRef cgPath;
#endif
#if OPENSWIFTUI_RENDERBOX
RBPath orbPath;
RBPath rbPath;
#else
ORBPath orbPath;
ORBPath rbPath;
#endif
uint8_t buffer[0x60];
} PathData;
Expand Down
Loading