-
Notifications
You must be signed in to change notification settings - Fork 61
[NFC] Use RB for properties and function and ORB for type #821
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -45,7 +45,7 @@ public struct _RendererConfiguration { | |
|
|
||
| /// When non-nil overrides colorMode with a member of the | ||
| /// `RBColorMode` enum, specified as its raw integer value. | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Severity: medium 🤖 Was this useful? React with 👍 or 👎, or 🚀 if it prevented an incident/outage. |
||
| public var orbColorMode: Int32? | ||
| public var rbColorMode: Int32? | ||
|
|
||
| /// When true the view will build and submit its command buffer | ||
| /// asynchronously. | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PlatformDrawableContent.Contentsappears to be part of the public surface here, and renaming enum cases (orbDisplayList→rbDisplayList,orbInterpolator→rbInterpolator) is a source-breaking change for downstream callers. If the intent is NFC, consider keeping the old case names as deprecated shims to preserve compatibility.Severity: medium
🤖 Was this useful? React with 👍 or 👎, or 🚀 if it prevented an incident/outage.