Various Release/Workflow plumbing items#22
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
This PR fixes #23 by updating the install-helm action to most current |
rwaffen
left a comment
rwaffen
left a comment
There was a problem hiding this comment.
generally looks ok, but i've got questions :D
| - name: Make the release | ||
| id: create_release | ||
| uses: actions/create-release@v1 | ||
| uses: softprops/action-gh-release@v2.6.1 |
There was a problem hiding this comment.
why use this action instead of github default one?
There was a problem hiding this comment.
the default one is long "archived" by GH and we want to use the auto-release notes functionality and this action allows for both this and the fact that we upload an asset to release (the packaged chart file) - i wish GH still maintained that create-release and kept it up to date
|
@rwaffen what questions remain at this point, would like to close this out so that i can start closing out other items |
|
@OpenVoxProject/container-maintainers can someone please review this part of this fixes current CI issues blocking closing of other PR's happy to discuss on slack or here more if any queries remain |
…herwise make the release process clearer
anthonysomerset
force-pushed
the
workflow-plumbing-updates
branch
from
3493816 to
d17ad2d
Compare
4 participants
Fixes #23
A number of small changes to optimise workflows and also to ideally align with how things are done within other repos within the project more generally - this will also simplify requirements for PR creators. e.g. not manually bumping the version and test versions for every single PR only for a release PR that bumps the version
note we likely will have some CI failures