Prevent redundant framebuffer attachment resizes and fix texture height check#795
Open
Gopmyc wants to merge 3 commits intoOverload-Technologies:mainfrom
Open
Prevent redundant framebuffer attachment resizes and fix texture height check#795Gopmyc wants to merge 3 commits intoOverload-Technologies:mainfrom
Gopmyc wants to merge 3 commits intoOverload-Technologies:mainfrom
Conversation
adriengivry
requested changes
May 2, 2026
Member
adriengivry
left a comment
There was a problem hiding this comment.
Only the changes in GLRenderBuffer.cpp and GLTexture.cpp should be kept
adriengivry
approved these changes
May 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes unnecessary framebuffer attachment resize/reallocation work in the editor rendering path and corrects a texture resize comparison bug.
Changes:
AView::Rendernow resizes the framebuffer only when viewport dimensions actually change.GLFramebuffer::Resizenow early-returns when current and requested sizes match.GLRenderbuffer::Resizenow early-returns when current and requested sizes match.GLTexture::Resizenow comparesp_heightagainstdesc.height(instead ofdesc.width).This removes repeated steady-state resize churn and avoids false-positive texture reallocations.
Related Issue(s)
Fixes #792
Review Guidance
Please review commit-by-commit:
fix(rendering): avoid redundant framebuffer resize reallocationsfix(rendering): correct height comparison in texture resizeScreenshots/GIFs
N/A
AI Usage Disclosure
N/A
Checklist
When applicable, I have commented my code, particularly in hard-to-understand areasWhen applicable, I have updated the documentation accordingly