Skip to content

Prevent redundant framebuffer attachment resizes and fix texture height check#795

Open
Gopmyc wants to merge 3 commits intoOverload-Technologies:mainfrom
Gopmyc:792
Open

Prevent redundant framebuffer attachment resizes and fix texture height check#795
Gopmyc wants to merge 3 commits intoOverload-Technologies:mainfrom
Gopmyc:792

Conversation

@Gopmyc
Copy link
Copy Markdown
Contributor

@Gopmyc Gopmyc commented May 2, 2026

Description

This PR fixes unnecessary framebuffer attachment resize/reallocation work in the editor rendering path and corrects a texture resize comparison bug.

Changes:

  • AView::Render now resizes the framebuffer only when viewport dimensions actually change.
  • GLFramebuffer::Resize now early-returns when current and requested sizes match.
  • GLRenderbuffer::Resize now early-returns when current and requested sizes match.
  • GLTexture::Resize now compares p_height against desc.height (instead of desc.width).

This removes repeated steady-state resize churn and avoids false-positive texture reallocations.

Related Issue(s)

Fixes #792

Review Guidance

Please review commit-by-commit:

  1. fix(rendering): avoid redundant framebuffer resize reallocations
  2. fix(rendering): correct height comparison in texture resize

Screenshots/GIFs

N/A

AI Usage Disclosure

N/A

Checklist

  • My code follows the project's code style guidelines
  • When applicable, I have commented my code, particularly in hard-to-understand areas
  • When applicable, I have updated the documentation accordingly
  • My changes don't generate new warnings or errors
  • I have reviewed and take responsibility for all code in this PR (including any AI-assisted contributions)

Copy link
Copy Markdown
Member

@adriengivry adriengivry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only the changes in GLRenderBuffer.cpp and GLTexture.cpp should be kept

Comment thread Sources/OvRendering/src/OvRendering/HAL/OpenGL/GLFramebuffer.cpp Outdated
Comment thread Sources/OvEditor/src/OvEditor/Panels/AView.cpp Outdated
@Gopmyc Gopmyc requested a review from adriengivry May 2, 2026 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

Fix framebuffer resize churn and texture resize bug

2 participants