Skip to content

Prevent redundant framebuffer attachment resizes and fix texture height check #795

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Gopmyc wants to merge 3 commits into
base: main
Choose a base branch
from
+7 −1
Open

Prevent redundant framebuffer attachment resizes and fix texture height check #795

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d1f0aa3
fix(rendering): avoid redundant framebuffer resize reallocations
Gopmyc May 2, 2026
623f74d
fix(rendering): correct height comparison in texture resize
Gopmyc May 2, 2026
a5ff8f5
chore(review): remove redundant framebuffer resize checks
Gopmyc May 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions Sources/OvRendering/src/OvRendering/HAL/OpenGL/GLRenderbuffer.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,6 +62,12 @@ template<>
void OvRendering::HAL::GLRenderbuffer::Resize(uint16_t p_width, uint16_t p_height)
{
OVASSERT(IsValid(), "Cannot resize a renderbuffer that has not been allocated");

if (m_context.width == p_width && m_context.height == p_height)
{
return;
}

Allocate(p_width, p_height, m_context.format);
}

Expand Down
2 changes: 1 addition & 1 deletion Sources/OvRendering/src/OvRendering/HAL/OpenGL/GLTexture.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -178,7 +178,7 @@ void OvRendering::HAL::GLTexture::Resize(uint32_t p_width, uint32_t p_height)

auto& desc = m_textureContext.desc;

if (p_width != desc.width || p_height != desc.width)
if (p_width != desc.width || p_height != desc.height)
{
desc.width = p_width;
desc.height = p_height;
Expand Down