Skip to content

feat: pass auth tokens by reference, not value#1362

Merged
jonathanlab merged 1 commit intomainfrom
refactor_pass_tokens_by_reference_not_by_value
Apr 1, 2026
Merged

feat: pass auth tokens by reference, not value#1362
jonathanlab merged 1 commit intomainfrom
refactor_pass_tokens_by_reference_not_by_value

Conversation

@jonathanlab
Copy link
Copy Markdown
Contributor

@jonathanlab jonathanlab commented Mar 30, 2026

Problem

We've split up the auth store in the previous PR into a service, but now we're not actually using it properly. A lot of services use their own (stale) local auth token value. We instead want to use the auth services token.

Changes

  • update main services to et auth token through AuthService instead of storing it away somewhere locally
  • agent package now accepts a get token and refresh token function instead of a token value
  • clean up a bunch of auth code

Copy link
Copy Markdown
Contributor Author

jonathanlab commented Mar 30, 2026

@jonathanlab jonathanlab marked this pull request as ready for review March 30, 2026 14:34
@jonathanlab jonathanlab force-pushed the 03-30-refactor_move_auth_to_main branch from 95069b4 to c0bb295 Compare March 31, 2026 11:50
@jonathanlab jonathanlab force-pushed the refactor_pass_tokens_by_reference_not_by_value branch from 7a165a4 to 98a1093 Compare March 31, 2026 11:50
@jonathanlab jonathanlab force-pushed the 03-30-refactor_move_auth_to_main branch from c0bb295 to ba27f7f Compare March 31, 2026 13:44
@jonathanlab jonathanlab force-pushed the refactor_pass_tokens_by_reference_not_by_value branch from 98a1093 to 5cb9976 Compare March 31, 2026 13:44
k11kirky
k11kirky previously approved these changes Mar 31, 2026
Copy link
Copy Markdown
Contributor Author

jonathanlab commented Apr 1, 2026

Merge activity

  • Apr 1, 9:59 AM UTC: A user started a stack merge that includes this pull request via Graphite.
  • Apr 1, 10:02 AM UTC: Graphite rebased this pull request as part of a merge.
  • Apr 1, 10:08 AM UTC: Graphite couldn't merge this PR because it was not satisfying all requirements (PR does not have required approvals).
  • Apr 1, 10:10 AM UTC: A user started a stack merge that includes this pull request via Graphite.
  • Apr 1, 10:10 AM UTC: @jonathanlab merged this pull request with Graphite.

@jonathanlab jonathanlab changed the base branch from 03-30-refactor_move_auth_to_main to graphite-base/1362 April 1, 2026 10:00
@jonathanlab jonathanlab changed the base branch from graphite-base/1362 to main April 1, 2026 10:00
@jonathanlab jonathanlab dismissed k11kirky’s stale review April 1, 2026 10:00

The base branch was changed.

@jonathanlab jonathanlab force-pushed the refactor_pass_tokens_by_reference_not_by_value branch from 5cb9976 to 82e277a Compare April 1, 2026 10:01
@jonathanlab jonathanlab merged commit 1c19ed5 into main Apr 1, 2026
16 checks passed
@jonathanlab jonathanlab deleted the refactor_pass_tokens_by_reference_not_by_value branch April 1, 2026 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants