feat: persist preferred project by account key

[jonathanlab]

Problem

Now we're not persisting preferred project on logout followed by login

Changes

persist it in sqlite, keying by region and account key

[jonathanlab]

• feat: improve auth service resilience #1367
• feat: persist preferred project by account key #1366 👈 (View in Graphite)
• refactor: hook up renderer auth logic to service #1365
• feat: pass auth tokens by reference, not value #1362
• refactor: move auth to main #1360
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

[graphite-app]

The auth_preferences table is missing a PRIMARY KEY or UNIQUE constraint on (account_key, cloud_region). This will allow duplicate rows to be inserted for the same account and region combination, causing unpredictable behavior in the get and save methods.

Impact: Multiple preference records can exist for the same account/region, and LIMIT 1 queries will return arbitrary rows. The update logic in save() may also fail to work correctly.

Fix: Add a composite primary key:

CREATE TABLE `auth_preferences` (
  `account_key` text NOT NULL,
  `cloud_region` text NOT NULL,
  `last_selected_project_id` integer,
  `created_at` text DEFAULT (CURRENT_TIMESTAMP) NOT NULL,
  `updated_at` text DEFAULT (CURRENT_TIMESTAMP) NOT NULL,
  PRIMARY KEY (`account_key`, `cloud_region`)
);

Suggested change

	CREATE TABLE `auth_preferences` (
	`account_key` text NOT NULL,
	`cloud_region` text NOT NULL,
	`last_selected_project_id` integer,
	`created_at` text DEFAULT (CURRENT_TIMESTAMP) NOT NULL,
	`updated_at` text DEFAULT (CURRENT_TIMESTAMP) NOT NULL
	);
	CREATE TABLE `auth_preferences` (
	`account_key` text NOT NULL,
	`cloud_region` text NOT NULL,
	`last_selected_project_id` integer,
	`created_at` text DEFAULT (CURRENT_TIMESTAMP) NOT NULL,
	`updated_at` text DEFAULT (CURRENT_TIMESTAMP) NOT NULL,
	PRIMARY KEY (`account_key`, `cloud_region`)
	);

Spotted by Graphite



Is this helpful? React 👍 or 👎 to let us know.

[jonathanlab]

Merge activity

• Apr 1, 9:59 AM UTC: A user started a stack merge that includes this pull request via Graphite.
• Apr 1, 10:08 AM UTC: Graphite couldn't merge this pull request because a downstack PR feat: pass auth tokens by reference, not value #1362 failed to merge.
• Apr 1, 10:10 AM UTC: A user started a stack merge that includes this pull request via Graphite.
• Apr 1, 10:22 AM UTC: Graphite rebased this pull request as part of a merge.
• Apr 1, 10:28 AM UTC: @jonathanlab merged this pull request with Graphite.