Merged
Conversation
Contributor
Author
This was referenced Apr 3, 2026
This was referenced Apr 3, 2026
charlesvien
approved these changes
Apr 3, 2026
k11kirky
force-pushed
the
04-03-feat_clean_up_session_reloadin
branch
from
fe3f90f to
9e67ff2
Compare
k11kirky
force-pushed
the
04-03-feat_update_codex_adapter_and_migrate_to_base_acp_prxy_for_agent
branch
from
bb3031e to
b772ead
Compare
Contributor
Author
k11kirky
changed the base branch from
04-03-feat_update_codex_adapter_and_migrate_to_base_acp_prxy_for_agent
to
graphite-base/1481
k11kirky
force-pushed
the
04-03-feat_clean_up_session_reloadin
branch
from
9e67ff2 to
21102e8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
simplify agent reconnection
Problem
The agent service had separate code paths for handling session reconnection between Codex and Claude adapters, leading to code duplication and inconsistent handling.
Changes
unstable_resumeSessionmethod, with Claude delegating to SDK's resumeSession and Codex delegating to codex-acp's loadSession internally