Skip to content

feat: give codex permissions support#1483

Merged
k11kirky merged 1 commit intomainfrom
04-03-feat_give_codex_permissions_support
Apr 6, 2026
Merged

feat: give codex permissions support#1483
k11kirky merged 1 commit intomainfrom
04-03-feat_give_codex_permissions_support

Conversation

@k11kirky
Copy link
Copy Markdown
Contributor

@k11kirky k11kirky commented Apr 3, 2026

support permission selector

Problem

The Codex agent needs to support different code execution modes with varying permission levels to provide better user control over what actions the agent can perform automatically.

Changes

  • Added support for code execution modes (default, acceptEdits, plan, bypassPermissions) in the Codex agent
  • Implemented automatic permission approval based on the current execution mode:
    • default: Auto-approves read, search, fetch, and think operations
    • acceptEdits: Additionally auto-approves edit operations
    • plan: Same as default (read-only operations)
    • bypassPermissions: Auto-approves all operation types
  • Added permissionMode tracking to session state to maintain the current execution mode
  • Modified setSessionMode to handle the mapping between ACP execution modes and Codex native modes
  • Enhanced the Codex client to check tool operation kinds against the current permission mode before requesting user approval

How did you test this?

Manual testing of each execution mode to verify that the appropriate operations are auto-approved and others still require user permission.

@charlesvien
Copy link
Copy Markdown
Member

charlesvien commented Apr 3, 2026

It tells me the full python command that it's going to run which may/may not be intentional, but when I accept the permission, it fails instantly, in both read-only and default permissions modes.

Also if I select "No, give feedback" then it interrupts. Did we want that to be the same as the claude adapter where we can type in that field and it will cancel, reprompt with the new instruction or is that out of scope?

The Prompt (I click yes, option 2 here):
CleanShot 2026-04-03 at 08 44 10@2x

The result:
CleanShot 2026-04-03 at 08 45 29@2x

Copy link
Copy Markdown
Member

If we're on the task input page, should we switch the shift+tab options if they select codex since they are different from claude? Supports ACP session modes: read-only, auto (default), and full-access.

@k11kirky k11kirky force-pushed the 04-03-feat_give_codex_permissions_support branch from be8d325 to 2009734 Compare April 6, 2026 16:23
@k11kirky k11kirky force-pushed the 04-03-feat_give_codex_system_prompt_via_personality branch from d04efd4 to 976a8df Compare April 6, 2026 21:16
@k11kirky k11kirky force-pushed the 04-03-feat_give_codex_permissions_support branch from 2009734 to 7669044 Compare April 6, 2026 21:16
Copy link
Copy Markdown
Contributor Author

k11kirky commented Apr 6, 2026

Merge activity

  • Apr 6, 9:47 PM UTC: A user started a stack merge that includes this pull request via Graphite.
  • Apr 6, 10:16 PM UTC: Graphite rebased this pull request as part of a merge.
  • Apr 6, 10:23 PM UTC: @k11kirky merged this pull request with Graphite.

@k11kirky k11kirky changed the base branch from 04-03-feat_give_codex_system_prompt_via_personality to graphite-base/1483 April 6, 2026 22:07
@k11kirky k11kirky changed the base branch from graphite-base/1483 to main April 6, 2026 22:14
@k11kirky k11kirky force-pushed the 04-03-feat_give_codex_permissions_support branch from 7669044 to 7b78843 Compare April 6, 2026 22:15
@k11kirky k11kirky merged commit 8afb366 into main Apr 6, 2026
16 checks passed
@k11kirky k11kirky deleted the 04-03-feat_give_codex_permissions_support branch April 6, 2026 22:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants