Merged
Conversation
This was referenced Apr 3, 2026
Contributor
Author
Member
|
It tells me the full python command that it's going to run which may/may not be intentional, but when I accept the permission, it fails instantly, in both read-only and default permissions modes. Also if I select "No, give feedback" then it interrupts. Did we want that to be the same as the claude adapter where we can type in that field and it will cancel, reprompt with the new instruction or is that out of scope? |
Member
|
If we're on the task input page, should we switch the shift+tab options if they select codex since they are different from claude? Supports ACP session modes: |
charlesvien
approved these changes
Apr 6, 2026
be8d325 to
2009734
Compare
d04efd4 to
976a8df
Compare
2009734 to
7669044
Compare
Contributor
Author
7669044 to
7b78843
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



support permission selector
Problem
The Codex agent needs to support different code execution modes with varying permission levels to provide better user control over what actions the agent can perform automatically.
Changes
default,acceptEdits,plan,bypassPermissions) in the Codex agentdefault: Auto-approves read, search, fetch, and think operationsacceptEdits: Additionally auto-approves edit operationsplan: Same as default (read-only operations)bypassPermissions: Auto-approves all operation typespermissionModetracking to session state to maintain the current execution modesetSessionModeto handle the mapping between ACP execution modes and Codex native modesHow did you test this?
Manual testing of each execution mode to verify that the appropriate operations are auto-approved and others still require user permission.