Repository navigation
fix(libcheck): pull an image that is not on the node yet - #163
Merged
Merged
Conversation
The kubelet device manager calls Allocate at pod admission, before it pulls the image. With -musl_fail_closed the first Pod to use an image failed admission because ctr could not mount it, and a rejected Pod never pulls the image, so every retry failed the same way. Start a background ctr pull when the image is missing and return ErrImageNotPresent, so the rejected Pod's replacement finds the image. Signed-off-by: mesutoezdil <mesudozdil@gmail.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: moezdil The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configuration
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
/kind bug
The kubelet device manager calls Allocate at pod admission, before it pulls the image. With
-musl_fail_closedthe first Pod to use an image failed admission becausectr images mountcould not find it, and a rejected Pod never pulls the image, so every retry failed the same way. This starts a backgroundctr images pullwhen the image is missing and returnsErrImageNotPresent, so the replacement Pod finds the image; Allocate does not wait for the pull.Refs #104
Reproduced on an MI325X node (k3s 1.37):
ubuntu:22.04anddebian:12-slimsliced Pods failed twice before; with the fix the first is rejected with "image is not on the node yet", the image is pulled, and the next Pod starts with LD_AUDIT and the memory limit. A musl image is still refused.AI assistance was used for this PR.