Repository navigation
fix(plugin): remove the node capacity entries when reporting is off - #164
Merged
Merged
Conversation
With -report_node_capacity the plugin patches amd.com/gpumem and amd.com/gpucores into the node status. Kubelet keeps an extended resource it did not advertise itself, so after turning the option off the old values stayed and kubelet rejected Pods asking for more than the stale amount. Clear the two resources when they are still listed and reporting is off, and grant the nodes/status patch permission unconditionally so the plugin may do so. Signed-off-by: mesutoezdil <mesudozdil@gmail.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: moezdil The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configuration
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
/kind bug
With
-report_node_capacitythe plugin patchesamd.com/gpumemandamd.com/gpucoresinto the node status. Kubelet keeps an extended resource it did not advertise itself, so after turning the option off the old values stayed and kubelet kept rejecting Pods that ask for more than the stale amount. The plugin now removes the two entries when they are still listed and reporting is off; the chart grantsnodes/statuspatch unconditionally, because the permission was only rendered with the option on and the clear failed withforbiddenotherwise.Refs #157
Verified on an MI325X node: with reporting on the node lists gpumem 261824 and gpucores 304; after switching it off both are gone from capacity and allocatable and a Pod asking for 200000 MiB schedules. The new unit test fails without the change.
AI assistance was used for this PR.