Repository navigation
refactor!: remove the legacy serialization formats (#206, #207, #208) - #241
Merged
Merged
Conversation
Delete `proto/`, the `proto` module and its vendored generated code, `tools/gen-proto`, the `prost` and `bytes` dependencies, the CI job that checked the vendored code, and the proto-only tests and fixtures (`tests/xtest_consumer.rs`, `tests/sketches_go_parity_probe.rs`, the envelope goldens). The KLL `KLLState` value-offset encoding goes with it. Closes #206 Closes #188 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Delete `message_pack_format::{portable, native}`, `MessagePackCodec` and its
`Error`: the wrapper types (`CountMinSketch`, `CountSketch`,
`CountMinSketchWithHeap`, `CountSketchWithHeap`, `KllSketch`, `HllSketch`,
`DdSketch`, `HydraKllSketch`), their deltas, heap items, sampling helpers and
constants, and the `xxhash-rust` dependency. Tests that exercised only the
wrappers go with them.
`SetAggregator` and `SetAggregatorDelta` move to `sketches::set_aggregator`
and stay re-exported at the crate root. The ASAPv1 framing (`envelope`,
`kind`, `delta`, `wire_key`, `admission_rate`) moves to the private module
`asapv1`; `peek_kind_id` stays at the crate root.
Closes #207
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Sketches, their storage (`Vector1D`/`2D`/`3D`, `BitMatrix`, `CommonHeap`, the fixed-structure macros) and their inputs stop implementing `Serialize` and `Deserialize`; serde stays on the ASAPv1 metadata and payload types. `CountMinHll` and `MicroCm` lose `serialize_to_bytes` / `deserialize_from_bytes`, and `serde-big-array` is dropped. KMV's decoder and the golden tests that built known states through serde now construct them directly; the known-state encode checks move into each sketch's `wire.rs`. Raw-serde tests go; tests of shared decode paths move to ASAPv1 or the rebuild they exercised. Closes #208 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Drop the Count-Min and Count Sketch `rows`/`cols` fields only serde read, the HLL wire re-exports only the portable path used, and imports the removals left unused; gate KMV's heap constructor on `experimental`; build the DDSketch admission golden from the decoded signed state; refresh the lockfile and the PBT law counts. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
GordonYuanyc
marked this pull request as ready for review
October 20, 2026 06:46
This was referenced Oct 20, 2026
This was referenced Oct 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #206, #207, #208, #188. Part of #179.
proto/, theprotomodule and generated code,tools/gen-proto,prost/bytes, and the vendored-proto CI job. The KLL value-offset form goes with it (ASAPv1: drop KLL value-offset encoding #188).message_pack_format::{portable, native},MessagePackCodec, the wrapper types and their deltas, the sampling helpers, andxxhash-rust. The ASAPv1 framing moves to a privateasapv1module.SetAggregatorand its delta move intosketches.peek_kind_idstays at the crate root.ASAPv1 bytes are unchanged; the goldens are untouched.
Locally: check, fmt, clippy (all-features, default, octo-runtime, experimental), rustdoc,
--libandasapv1_golden. Goldens built through serde or portable types now build state directly; each kind has aknown_state_matches_goldentest.Not carried over: portable-only property laws. Native Count-Min and Count Sketch currently have no merge-algebra pbt laws, which is a follow-up. Nitro's raw-serde continuation tests are gone, since Nitro has no ASAPv1 form.
🤖 Generated with Claude Code