Group plain imports - #2614
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2614 +/- ##
==========================================
- Coverage 99.39% 99.33% -0.07%
==========================================
Files 41 41
Lines 3163 3172 +9
Branches 682 686 +4
==========================================
+ Hits 3144 3151 +7
- Misses 11 12 +1
- Partials 8 9 +1 🚀 New features to boost your workflow:
|
873f015 to
300a1dc
Compare
cefc0d0 to
52f4789
Compare
cc796a7 to
109c47b
Compare
f693a88 to
a4f5d68
Compare
e7cc475 to
3a6f53f
Compare
3a6f53f to
a114126
Compare
|
@DanielNoord on a first look I see:
If you want I can try to do commits to help this PR as well. |
|
Doesn't this address it? I thought it did but might need to double check. I think the original error is just attributing an underlying problem (not merging/grouping plain from imports) to unrelated configuration options. |
There was a problem hiding this comment.
@DanielNoord sorry, I double-checked and the core behavior looks correct: the original multiline reproducer groups all plain imports into one statement, keeps the aliased import separate, and is idempotent with and without --fss.
I would propose to close this:
- Add the exact long multiline #2455 reproducer as a regression test.
- Add the reverse alias-before-plain case and assert idempotency.
- Keep the Django and Habitat skips, but clarify that they reflect incompatibility with the intentional breaking style.
Closes #2455
Code is still to be improved. I'm also unsure about some of the changes to expected test output...