[FIX] Minor bug fixes#587
Closed
HumphreyYang wants to merge 3 commits into
Closed
Conversation
✅ Deploy Preview for taupe-gaufre-c4e660 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
|
@HumphreyYang please ping me when you're ready for review. |
Member
Author
Many thanks @mmcky, this PR is under Tom's review so I will update once I have more information! |
Contributor
|
This branch has merge conflicts with main and needs to be rebased. |
Contributor
|
Closing in favor of #753, which re-applies these bug fixes onto current main. Thanks @HumphreyYang. |
jstac
added a commit
that referenced
this pull request
May 28, 2026
In cons_smooth.md and tax_smooth.md:
- Fix budget constraint computation: missing factor of R in
np.linalg.inv(A) @ b (should be @ (R * b)).
- Fix plot functions referencing global cs_model/tax_model instead
of the model argument, which would silently ignore the model
parameter if the function is called with a different model.
In cagan_ree.md:
- Fix off-by-one timing in μ_seq construction and continuation paths.
- Add π_seq_2 boundary adjustment at T1-1 for regime continuity.
- Fix swapped Smooth/Jumpy labels in the p-plot (now reads as $m_{T_1}$
to match the m-plot variants).
- Add note that γ* = 1 is assumed in solve().
Extracted from #587 (HumphreyYang) onto current main.
Co-authored-by: Humphrey Yang <u6474961@anu.edu.au>
Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes some minor timing inconsistency and code bug in
cagan_ree,tax_smoothing, andcons_smoothing.