Fix timing inconsistencies and code bugs (re-base of #587)#753
Merged
Conversation
In cons_smooth.md and tax_smooth.md:
- Fix budget constraint computation: missing factor of R in
np.linalg.inv(A) @ b (should be @ (R * b)).
- Fix plot functions referencing global cs_model/tax_model instead
of the model argument, which would silently ignore the model
parameter if the function is called with a different model.
In cagan_ree.md:
- Fix off-by-one timing in μ_seq construction and continuation paths.
- Add π_seq_2 boundary adjustment at T1-1 for regime continuity.
- Fix swapped Smooth/Jumpy labels in the p-plot (now reads as $m_{T_1}$
to match the m-plot variants).
- Add note that γ* = 1 is assumed in solve().
Extracted from #587 (HumphreyYang) onto current main.
Co-Authored-By: Humphrey Yang <u6474961@anu.edu.au>
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
✅ Deploy Preview for taupe-gaufre-c4e660 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR extracts the bug fixes from #587 (HumphreyYang) and applies them onto current main. The original PR could not be rebased cleanly due to extensive other changes on these files.
Summary
In
cons_smooth.mdandtax_smooth.md:np.linalg.inv(A) @ b(should be@ (R * b)).plot_cs/plot_tsfunctions referencing globalcs_model/tax_modelinstead of themodelargument — the functions would silently ignore the model parameter if called with a different model.In
cagan_ree.md:μ_seqconstruction and continuation paths.π_seq_2boundary adjustment atT1-1for regime continuity.$m_{T_1}$to match the m-plot variants).γ* = 1is assumed insolve().Original PR: #587
Co-authored-by: HumphreyYang
🤖 Generated with Claude Code