Repository navigation
refactor(ui): migrate views to Querya UI Kit and add architectural guard tests (#1039) - #1074
Merged
Merged
Conversation
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Migrates all legacy raw Material components (
AlertDialogandCircularProgressIndicator) and custom search inputs acrosslib/to Querya UI Kit design system components (QueryaModalDialog,QueryaConfirmDialog,QueryaSpinner,QueryaSearchField). Also introduces CI architectural guard tests to prevent regression.Closes #1039
Key Changes
AlertDialogoccurrences across database view modules (SQLite, PostgreSQL, MySQL, Redis, Extensions, Settings/Themes) withQueryaModalDialogandQueryaConfirmDialog.QueryaModalDialogactions to useWrapto ensure action buttons never causeRenderFlexoverflow on narrow dialog layouts.material.CircularProgressIndicatoroccurrences acrosslib/withQueryaSpinner(using appropriate size tokens:.sm,.md,.lgand optional labels/colors).lib/shared/widgets/querya_spinner.dartremains as the design-system provider of the underlying progress widget.RedisKeysView,MongoDocumentsView, andResultsTabwithQueryaSearchField.test/guards/no_raw_material_dialogs_test.dartto assert zero rawAlertDialogusages acrosslib/.test/guards/no_raw_progress_indicators_test.dartto assert zero rawCircularProgressIndicatorusages acrosslib/(exemptingquerya_spinner.dart).no_material_dropdowns_test.dart.Verification
flutter analyze: 0 issues found (clean).flutter test test/guards/: 3/3 guard suites passed.flutter test: 1,954+ unit & widget tests passed.