Repository navigation
fix(ext-tester): set the process exit code (main's return value is ignored) - #1485
Merged
Merged
Conversation
…nored querya-ext-tester declared Future<int> main and returned 0 / 1 / 2, but Dart ignores the return value of main: every run exited 0, so CI could not fail on a broken extension and the release smoke test (an empty directory must exit 1) failed. The code is now assigned to exitCode.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Second hotfix for the 0.4.19 Release run. After #1484 Build macOS and the tester compile pass; what is left is the smoke test of
querya-ext-tester(https://github.com/QueryaHub/Querya-Desktop/actions/runs/38150816601, jobs Build querya-ext-tester on all platforms).Cause
bin/querya_ext_tester.dartdeclaresFuture<int> main(...)and returns0/1/2, but a Dart program ignores the return value ofmain: every run exits 0. The workflow's smoke test (an empty directory has no manifest.json: the run must fail with exit code 1) correctly failed on that. It also means the tester has never failed a CI pipeline of an extension author, so it is a real bug of the shipped tool, not just of the smoke test.Fix
mainassignsexitCode = await _run(args).Checked locally
Built with
scripts/ci/build_ext_tester.shand ran the binary: an empty directory exits 1,--helpexits 0, no arguments exit 2. The MCP smoke commands of the same step (--help,initializewithout an endpoint file, exit 1 and the message) also pass locally.Cut from
684ee7b2(the commit the0.4.19tag points at), sopubspec.yamlis still0.4.19+2.