Skip to content

fix(ext-tester): set the process exit code (main's return value is ignored) #1485

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ZhuchkaTriplesix merged 1 commit into from
Oct 11, 2026
Merged

fix(ext-tester): set the process exit code (main's return value is ignored) #1485

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion bin/querya_ext_tester.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,13 @@ Options:
-h, --help show this help
''';

Future<int> main(List<String> args) async {
/// The exit code is set through `exitCode`: a Dart `main` cannot return one
/// (the `Future<int>` it used to return was ignored, so a failed run exited 0).
Future<void> main(List<String> args) async {
exitCode = await _run(args);
}

Future<int> _run(List<String> args) async {
String? dir;
var target = '0.5.0';
String? connect;
Expand Down
Loading