Skip to content

fix(theme): use theme border token for preview swatches and add mono fallback (#1654) - #1655

Merged
ZhuchkaTriplesix merged 1 commit into
devfrom
issue/1654-theme-swatches-and-mono
Oct 17, 2026
Merged

ZhuchkaTriplesix merged 1 commit into
devfrom
issue/1654-theme-swatches-and-mono

Conversation

@ZhuchkaTriplesix

Copy link
Copy Markdown
Member

Summary

  • In ThemePreviewCard, replace hardcoded black border in _Swatch with ambient theme border token (Theme.of(context).colorScheme.border.withValues(alpha: 0.6)), ensuring swatch outlines remain visible across dark themes (Dracula, One Dark, Tokyo Night, Monokai).
  • In ThemeEditorDialog, add QueryaTypography.monoFontFamilyFallback to _ThemeEditorColorRow hex label.
  • Add test assertions to verify swatch border color derivation and mono font stack fallback.

Linked issue

Closes #1654

Checklist

  • flutter analyze and flutter test pass locally
  • Scope matches the linked issue only (no drive-by refactors)
  • PR targets dev

@github-actions github-actions Bot added bug Something isn't working theme Theming, colors, VS Code themes frontend Theme parser epic label: frontend settings Theme parser epic label: settings labels Oct 17, 2026
@github-actions github-actions Bot added this to the Theme system milestone Oct 17, 2026
@ZhuchkaTriplesix
ZhuchkaTriplesix merged commit ae78124 into dev Oct 17, 2026
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working frontend Theme parser epic label: frontend settings Theme parser epic label: settings theme Theming, colors, VS Code themes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant