Skip to content

fix(macos): title-bar inset vs traffic lights; log Postgres connect errors #1755

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ZhuchkaTriplesix merged 2 commits into from
Oct 25, 2026
Merged

fix(macos): title-bar inset vs traffic lights; log Postgres connect errors #1755

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
adcf55a
fix(macos): title-bar inset ignores UI scale so the icon stays clear …
ZhuchkaTriplesix Oct 25, 2026
585b887
feat(postgres): log connect attempts and the raw error when a connect…
ZhuchkaTriplesix Oct 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions lib/core/database/postgres_connection.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -261,6 +261,11 @@ class PostgresConnection {
effectiveConnectionString = secrets.connectionString;
}

final viaUri = _usesConnectionString(effectiveConnectionString);
debugPrint(
'PostgresConnection.connect: host=$host port=$port db=$database '
'user=$username viaUri=$viaUri useSSL=$useSSL ssh=${sshConfig != null}',
);
try {
if (sshConfig != null && sshConfig!.enabled) {
var sec = sshSecrets;
Expand Down Expand Up @@ -340,6 +345,10 @@ class PostgresConnection {
_inTransaction = false;
scrubCredentials();
} catch (e, st) {
debugPrint(
'PostgresConnection.connect failed: host=$host port=$port '
'viaUri=$viaUri error=${e.runtimeType}: $e\n$st',
);
_isConnected = false;
_conn = null;
try {
Expand Down
5 changes: 3 additions & 2 deletions lib/features/main_screen/querya_window_title_bar.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,8 +79,9 @@ class QueryaWindowTitleBar extends StatelessWidget {
required bool isMacOS,
required double Function(double designPx) scale,
}) {
// macOS traffic lights sit in the transparent titlebar (bitsdojo custom frame).
return scale(isMacOS ? 72 : 16);
// macOS traffic lights sit in the transparent titlebar (bitsdojo custom
// frame) and are native, so they ignore the in-app UI scale.
return isMacOS ? 80 : scale(16);
}

/// Bitsdojo chrome buttons duplicate system traffic lights on macOS.
Expand Down
4 changes: 2 additions & 2 deletions test/features/main_screen/querya_window_title_bar_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,9 +111,9 @@ void main() {
expect(
QueryaWindowTitleBar.titleBarLeadingInset(
isMacOS: true,
scale: (v) => v,
scale: (v) => v * 0.8,
),
72,
80,
);
expect(
QueryaWindowTitleBar.titleBarLeadingInset(
Expand Down
Loading