Skip to content

fix(connections): report and log a failed save of a new connection - #1757

Merged
ZhuchkaTriplesix merged 2 commits into
devfrom
fix/surface-connection-save-errors
Oct 25, 2026
Merged

ZhuchkaTriplesix merged 2 commits into
devfrom
fix/surface-connection-save-errors

Conversation

@ZhuchkaTriplesix

Copy link
Copy Markdown
Member

Creating a connection wrote the row, then the password to the system keyring, and rolled the row back if that write threw. The creation paths did not catch it: the form closed, the connection was missing and nothing was shown. Editing a connection already showed a toast; creating did not.

  • `saveNewConnection` (connection_creation_flow.dart) stores the row, and on failure logs the error type and stack with `debugPrint` and shows "The connection was not saved. …".
  • Used by every creation path: the connections panel (add button, folder menu) and the four flows in `MainScreenDialogs` (form, URL, SQLite, hero).
  • Not covered: the scratch connection of a file opened from the file manager and the demo playground; their own error handling is unchanged.

This surfaces the failure; it does not change why a save can fail. Reported on macOS beta 0.5.0-beta.1, where the cause is still unknown (the login-keychain fix #1586 is already in that build). With this build the real error appears in the toast and the log. Not run on a Mac.

@github-actions github-actions Bot added bug Something isn't working stability Theme parser epic label: stability connections Database connections, URI parsing, pools P1 High priority / Core capability labels Oct 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working connections Database connections, URI parsing, pools P1 High priority / Core capability stability Theme parser epic label: stability

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant