Repository navigation
fix(connections): report and log a failed save of a new connection - #1757
Merged
Merged
Conversation
… logged instead of vanishing
This was referenced Oct 25, 2026
…ports a failed save
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Creating a connection wrote the row, then the password to the system keyring, and rolled the row back if that write threw. The creation paths did not catch it: the form closed, the connection was missing and nothing was shown. Editing a connection already showed a toast; creating did not.
This surfaces the failure; it does not change why a save can fail. Reported on macOS beta 0.5.0-beta.1, where the cause is still unknown (the login-keychain fix #1586 is already in that build). With this build the real error appears in the toast and the log. Not run on a Mac.