Skip to content

ci: prefer commit-specific Aiter S3 manifest - #1933

Open
gyohuangxin wants to merge 1 commit into
mainfrom
ci/use-aiter-commit-s3-manifest
Open

ci: prefer commit-specific Aiter S3 manifest#1933
gyohuangxin wants to merge 1 commit into
mainfrom
ci/use-aiter-commit-s3-manifest

Conversation

@gyohuangxin

@gyohuangxin gyohuangxin commented Aug 17, 2026

Copy link
Copy Markdown
Member

Summary

  • Keep the existing S3-first Aiter wheel resolver
  • When main/latest.json is stale, try commits/<Aiter SHA>/latest.json from S3 before falling back to GitHub artifacts
  • Verify the commit-specific manifest commit matches the latest Aiter artifact SHA

Why

ATOM currently falls back to GitHub artifacts if CloudFront serves a stale Aiter main/latest.json. This lets ATOM still use S3 once Aiter publishes the immutable commit-specific manifest.

Depends on ROCm/aiter#4807.

Validation

  • bash -n .github/scripts/download_aiter_wheel.sh
  • git diff --check

Copilot AI lite review requested due to automatic review settings August 17, 2026 15:30

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@github-actions

Copy link
Copy Markdown
Contributor

🏷️ CI Guide

Runs automatically on every eligible PR before approval:

  • ✅ Pre Checkin: Black, Ruff, catalog schema validation, non-GPU unit tests

Heavy model tests:

  • ✅ Run after the PR is approved and Pre Checkin passes
  • ✅ Run immediately when an approval review is submitted
  • ✅ Can be requested before approval with labels
Label Tests
ci:full Run all heavy PR model tests: native ATOM, vLLM, and SGLang
ci:atom Run native ATOM model accuracy tests
ci:vllm Run ATOM vLLM OOT model accuracy tests
ci:sglang Run ATOM SGLang model accuracy tests

Heavy jobs are skipped when the PR is not approved and no matching ci:* label is present.
Add labels via the sidebar or gh pr edit 1933 --add-label <label>

@zufayu
zufayu requested a review from valarLip August 18, 2026 02:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants