Skip to content

ci: make Aiter S3 wheel manifest cache-safe - #4807

Open
gyohuangxin wants to merge 1 commit into
mainfrom
ci/fix-s3-aiter-manifest
Open

ci: make Aiter S3 wheel manifest cache-safe#4807
gyohuangxin wants to merge 1 commit into
mainfrom
ci/fix-s3-aiter-manifest

Conversation

@gyohuangxin

@gyohuangxin gyohuangxin commented Aug 17, 2026

Copy link
Copy Markdown
Member

Summary

  • URL-encode Aiter wheel filenames in the published S3 manifest so wheels containing + download correctly through CloudFront
  • Upload a commit-specific manifest at commits/<sha>/latest.json for immutable S3 consumers
  • Publish main/latest.json with no-store cache control and optionally invalidate CloudFront when AITER_WHEEL_CLOUDFRONT_DISTRIBUTION_ID is configured

Why

ATOM is S3-first, but it falls back to GitHub artifacts when CloudFront serves a stale main/latest.json. The immutable commit manifest gives downstream jobs a cache-safe S3 path for the exact Aiter artifact commit.

Paired ATOM consumer change: ROCm/ATOM#1933.

Validation

  • Parsed .github/workflows/aiter-test.yaml with PyYAML
  • git diff --check

@gyohuangxin
gyohuangxin requested review from a team and a lite review from Copilot August 17, 2026 15:30
@github-actions

Copy link
Copy Markdown
Contributor

🏷️ CI Guide

Runs automatically on every PR:

  • ✅ Pre-checks (submodule verification, code formatting)
  • ✅ Aiter op tests (gfx942 + gfx950)
  • ✅ Triton tests on MI35X (only when aiter/ops/triton/** or related paths are changed)

Extended tests (opt-in via labels):

Label Tests
ci:gfx1250-ffm-triton Run the five-shard gfx1250 FFM Triton test suite
ci:triton-300x Run an additional Triton test job on MI300X in PRs; main branch always runs both MI35X and MI300X
ci:sglang SGLang integration tests: DeepSeek-R1-MXFP4 accuracy, Qwen 3.5 accuracy
ci:atom ATOM benchmark: DeepSeek-R1-0528, GPT-OSS-120B
ci:atom_full ATOM accuracy suite for PR and main models from ATOM models_accuracy.json
ci:vllm vLLM benchmark: GPT-OSS-120B, DeepSeek-R1-0528, Kimi-K2.5
ci:all All standard extended tests (excludes ci:atom_full)

Only add ci:atom_full for FlyDSL or Triton upgrades.
Add labels via the sidebar or gh pr edit 4807 --add-label <label>

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants