chore(packaging): add missing __init__.py for cvs.tests subpackages - #314
Open
speriaswamy-amd wants to merge 1 commit into
Open
chore(packaging): add missing __init__.py for cvs.tests subpackages#314speriaswamy-amd wants to merge 1 commit into
speriaswamy-amd wants to merge 1 commit into
Conversation
setup.py builds its package list with find_packages(where="cvs"), which only walks directories containing __init__.py. Most cvs/tests/* suite directories had none, so they were silently dropped from the sdist and from `pip install` / `pip install -e .` installs. Adding the 15 missing files makes 17 subpackages discoverable, including tests.inference.pytorch_xdit and tests.training.jaxmaxtext, which were excluded only because an intermediate parent directory lacked __init__.py. Co-Authored-By: Claude <noreply@anthropic.com>
amd-droy
approved these changes
Aug 17, 2026
amd-droy
left a comment
amd-droy
left a comment
Contributor
There was a problem hiding this comment.
looks good to me. Thanks Surya.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part 1 of 12 in a stack that replaces #184. Base:
main.Why
setup.pybuilds its package list withfind_packages(where="cvs"), which only walks directories containing__init__.py. Mostcvs/tests/*suite directories have none, so they are silently dropped from the sdist and frompip install/pip install -e ..What changed
__init__.pyfiles undercvs/tests/.This makes 17 subpackages discoverable. Two of them —
tests.inference.pytorch_xditandtests.training.jaxmaxtext— already had their own__init__.pyand were excluded only because a parent directory did not.No behaviour change for anyone running from a source checkout.