fix(tests): make missing-file test self-contained - #315
Open
speriaswamy-amd wants to merge 3 commits into
Open
Conversation
…ator test_missing_file_raises asserted FileNotFoundError against the hardcoded absolute path /nonexistent/path/cluster.json. That is environment-dependent (AGENTS.md forbids it) and would silently stop testing what it claims to test if such a path ever existed. It now builds the missing path inside a TemporaryDirectory, matching the sibling test_invalid_json_raises_value_error. Also replaces the '%%%%%%%%%' separator in one ibperf log line with '======='. Note: the same '%%%' separator style appears elsewhere in ibperf, rccl_lib and mori_lib and is left alone here; this single line is drive-by cleanup and can be dropped if reviewers prefer the file stay consistent with its neighbours. Co-Authored-By: Claude <noreply@anthropic.com>
…t-and-log-fixes (bring branch up to date)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part 2 of 12 in a stack that replaces #184. Base: #314.
Why
test_missing_file_raisesassertedFileNotFoundErroragainst the hardcoded absolute path/nonexistent/path/cluster.json. That is environment-dependent (AGENTS.md forbids it) and would stop testing what it claims to test if such a path ever existed.What changed
cvs/monitors/unittests/test_check_cluster_health.py— build the missing path inside aTemporaryDirectory, matching the siblingtest_invalid_json_raises_value_error.cvs/tests/ibperf/ib_perf_bw_test.py— one log separator%%%%%%%%%→=========.The ibperf line is unrelated drive-by cleanup. The same
%%%style appears elsewhere inib_perf_bw_test.py,rccl_lib.pyandmori_lib.pyand is untouched, so this leaves the file internally inconsistent — happy to drop that hunk if reviewers prefer.