fix(megatron_training_lib): compare verify_network_errors as the string it is - #334
Open
speriaswamy-amd wants to merge 1 commit into
Open
fix(megatron_training_lib): compare verify_network_errors as the string it is#334speriaswamy-amd wants to merge 1 commit into
speriaswamy-amd wants to merge 1 commit into
Conversation
…ng it is self.verify_network_errors is always the string 'True'/'False' parsed from JSON, so `is True` can never be true and the post-run RDMA/ethtool error-counter comparison silently never runs. Matches the working `== 'True'` pattern already used for the same field elsewhere. AIMVT-276.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part 1 of 14 in a stack for AIMVT-276.
Why
self.verify_network_errorsis always the string'True'/'False'parsed from JSON config, never a Python bool.if self.verify_network_errors is True:can therefore never be true, so the post-run RDMA/ethtool error-counter comparison silently never runs for distributed training jobs, regardless of what the config says.What changed
cvs/lib/megatron_training_lib.py— compare with== 'True'instead ofis True, matching the working pattern already used for the same field intorchtitan_training_lib.py.