refactor(cli_plugins): hoist _emit_error onto SubcommandPlugin - #337
Open
speriaswamy-amd wants to merge 1 commit into
Open
refactor(cli_plugins): hoist _emit_error onto SubcommandPlugin#337speriaswamy-amd wants to merge 1 commit into
speriaswamy-amd wants to merge 1 commit into
Conversation
exec_plugin.py had its own _emit_error (print to stderr in JSON mode so stdout stays valid JSON, else stdout). A second plugin needing the same behavior is coming next in this stack; move it onto the shared base rather than paste a second copy. AIMVT-276.
speriaswamy-amd
force-pushed
the
speriaswamy/cvsman-04-emit-error-base
branch
from
August 14, 2026 20:33
57b211f to
bfa69f1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part 4 of 14 in a stack for AIMVT-276. Base: #336.
Why
_emit_error(print to stderr in--jsonmode so stdout stays valid JSON, else stdout) lived only onExecPlugin. A second plugin needing identical behavior is coming later in this stack — better to share it than paste a second copy.What changed
cvs/cli_plugins/base.py— added_emit_errortoSubcommandPlugin.cvs/cli_plugins/exec_plugin.py— removed its now-redundant copy.