docs(compass): describe the agent's real session protocol, not ACP (RIG-1329) - #1266
Open
rigel-mintaka wants to merge 2 commits into
Conversation
|
Compass engineering docs preview: https://compass-agent-rig-1329-purge.compass-eng-docs.pages.dev Deployed from |
rigel-mintaka
force-pushed
the
compass-agent/rig-1329-purge-acp-terminology
branch
from
September 17, 2026 02:32
2e92873 to
6eaaf57
Compare
…IG-1329) The in-container agent is the first-party SDK agent — `CompassAgent` wraps `Agent` and drives a typed `AgentFrame`/`AgentControl` protocol over stdio. ACP is no longer used anywhere, but the term survived in comments. The mapper comments were the costly ones: they cited `acp-event-mapper.ts` line-for-line (`:130`, `:247`, `:255`, `:378`) for behaviour this file now owns outright, pointing every reader at a file that does not exist. Proto doc-comments are fixed at the source and regenerated, never hand-edited; the generated diff is comment-only. Internal `.acp*` CSS selectors are renamed to `.session*`. Fixture identifiers and historical design records keep the term: they record what was named or decided then, and the comms fixtures are asserted by id. Co-authored-by: Matt Wilkinson <matt@rigel.build>
Review found the rewrite deleted normative statements that carried no ACP terminology, so a purge narrowed the documented contract in four checked-in client surfaces. Restored: AgentWorkspace is "no longer a message container" and its access is a projection of channel membership "rather than a separate participant ACL"; the execution trace goes on a dedicated stream "not as comms blocks", which is the prohibition a producer reads. Two comments had become wrong rather than merely shorter. `planStatus` no longer said "abandoned" folds to COMPLETED, which a reader would infer as PENDING from the surrounding text — the opposite of the code. The readers' header lost the reason they exist (the SDK types tool payloads as `any`) and restated what the next comment already said. Also: an em-dash lost its pair in the file header, `adapt.ts` kept a line citation pointing at unrelated code (now a symbol reference), and a CSS comment named a "session view" that does not exist. Co-authored-by: Matt Wilkinson <matt@rigel.build>
rigel-mintaka
force-pushed
the
compass-agent/rig-1329-purge-acp-terminology
branch
from
September 17, 2026 02:42
6eaaf57 to
41b0d47
Compare
rigel-mintaka
force-pushed
the
compass-agent/rig-1544-ask-whitespace-fidelity
branch
from
September 17, 2026 02:42
82b7657 to
18fd8fe
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is part of a stack containing 3 PRs:
mainThe in-container agent is the first-party SDK agent —
CompassAgentwrapsAgentand drives a typedAgentFrame/AgentControlprotocol over stdio.ACP is no longer used anywhere, but the term survived in comments.
The mapper comments were the costly ones: they cited
acp-event-mapper.tsline-for-line (
:130,:247,:255,:378) for behaviour this file nowowns outright, pointing every reader at a file that does not exist.
Proto doc-comments are fixed at the source and regenerated, never hand-edited;
the generated diff is comment-only. Internal
.acp*CSS selectors are renamedto
.session*.Fixture identifiers and historical design records keep the term: they record
what was named or decided then, and the comms fixtures are asserted by id.
Co-authored-by: Matt Wilkinson matt@rigel.build