ci(dogfood-e2e): hand the file-command files to podman instead of a+rw (RIG-2131) - #1267
Open
rigel-mintaka wants to merge 1 commit into
Conversation
This was referenced Sep 17, 2026
|
Compass engineering docs preview: https://compass-agent-rig-2131-scope.compass-eng-docs.pages.dev Deployed from |
rigel-mintaka
force-pushed
the
compass-agent/rig-2131-scope-podman-chmod
branch
from
September 17, 2026 02:32
2cd8629 to
1c05efa
Compare
rigel-mintaka
force-pushed
the
compass-agent/rig-1329-purge-acp-terminology
branch
from
September 17, 2026 02:32
2e92873 to
6eaaf57
Compare
Review found `chown -R` moves the directory's ownership too. The runner re-creates a fresh per-step file-command file before every step, and creating a file needs write on the DIRECTORY — so handing the directory to uid 1000 made every later step depend on the runner process being uid 0, a dependency the world-writable version did not have. Narrow to `find -type f`, which leaves the directory root-owned. The append still works: the files themselves are podman-owned at 644. Also correct two comments that outlived the behaviour they describe — the prep step still said root was needed to `chmod` these files, and the job explainer said the wrapper chowns the dir. Co-authored-by: Matt Wilkinson <matt@rigel.build>
rigel-mintaka
force-pushed
the
compass-agent/rig-2131-scope-podman-chmod
branch
from
September 17, 2026 02:42
1c05efa to
bf05c12
Compare
rigel-mintaka
force-pushed
the
compass-agent/rig-1329-purge-acp-terminology
branch
from
September 17, 2026 02:42
6eaaf57 to
41b0d47
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is part of a stack containing 3 PRs:
mainThe podman-step wrapper made the runner's per-step file-command files
world-writable so the non-root podman user could append to $GITHUB_PATH and
$GITHUB_OUTPUT. Only uid 1000 needs that write.
Transfer ownership while the wrapper is still root instead. The files keep
0644, so the append works without granting write to every user.
The change is deliberately minimal — this path took many CI iterations to get
green under rootless podman in a privileged container, and the surrounding
wrapper is untouched.
Co-authored-by: Matt Wilkinson matt@rigel.build