Skip to content

BUG: Remove duplicate controller call in Flight.__simulate #960

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Krissal1234 wants to merge 2 commits into
base: master
Choose a base branch
from
+1 −9
Open

BUG: Remove duplicate controller call in Flight.__simulate #960

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9839fad
BUG: Remove duplicate controller call in Flight.__simulate
Krissal1234 May 8, 2026
52f9086
MNT: update CHANGELOG for #959
Krissal1234 May 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,6 +89,7 @@ Attention: The newest changes should be on top -->
- BUG: Duplicate _controllers in Flight.TimeNodes.merge() [#931](https://github.com/RocketPy-Team/RocketPy/pull/931)
- BUG: Fix incorrect Jacobian in `only_radial_burn` branch of `SolidMotor.evaluate_geometry` [#935](https://github.com/RocketPy-Team/RocketPy/pull/935)
- BUG: Add explicit timeouts to ThrustCurve API requests [#935](https://github.com/RocketPy-Team/RocketPy/pull/935)
- BUG: Remove duplicate controller call in Flight.__simulate [#959](https://github.com/RocketPy-Team/RocketPy/issues/959)

## [v1.11.0] - 2025-11-01

Expand Down
9 changes: 0 additions & 9 deletions rocketpy/simulation/flight.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -698,15 +698,6 @@ def __simulate(self, verbose):

self.__process_sensors_and_controllers_at_current_node(node, phase)

for controller in node._controllers:
controller(
self.t,
self.y_sol,
self.solution,
self.sensors,
self.env,
)

for parachute in node.parachutes:
# Calculate and save pressure signal
(
Expand Down