Add explicit scope display and focus controls - #3
Conversation
|
感谢把
项目已经有独立的仪器插件仓库,并且其中已有:
因此希望在合并前调整 PR 边界,并修复下面的状态安全问题。当前结论是 Request changes / 暂不按现状合并。 1. 请拆分通用控制面与具体仪器实现这个 PR 在 WaveBench 主仓库中可以保留以下通用部分:
以下内容请迁移到仪器插件仓库对应的包中:
主仓库里的内建兼容驱动可以继续保留现有基线,但在没有完成同等安全实现和验证前,不应提前声明新的 display/focus capability。增强能力可以先通过外置插件的 canonical driver ID 提供。 2.
|
218cd07 to
de78947
Compare
|
Thanks for the detailed boundary and safety review. I updated this PR to make it a main-repo shared control-surface PR only:
Validation after rebasing onto current The DS1000Z and RTM2000/RTM2032 concrete implementations are now left for the instrument plugin repo as requested. |
Summary
wavebench scope display --channel N on|offwavebench scope focus --channel Nwith time range, vertical scale, and hide-other-channel options*OPC?during autoscale to avoid response desyncSafety
Validation
git diff --cached --checkpytest -q tests/test_cli.py tests/test_ds1104.py tests/test_instrument_models.py tests/test_scope_snapshot.py tests/test_waveform.py: 132 passed, 1 warning, 5 subtests passedSplit context
This is split out from the original AI-agent scope PR so scope state-changing controls can be reviewed separately from MCP/agent read APIs.