Attempt the implementation of missing reinit! for dual cache #836
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChrisRackauckas
approved these changes
Dec 8, 2025
jClugstor
reviewed
Dec 8, 2025
test/forwarddiff_overloads.jl
Outdated
| reinit!(cache; A = sparse(A)) | ||
| overload_x_p = solve!(cache, UMFPACKFactorization()) | ||
| backslash_x_p = A \ b | ||
| @test ≈ (overload_x_p, backslash_x_p, rtol = 1e-9) |
Member
There was a problem hiding this comment.
I believe there's an extra space here?
ext/LinearSolveForwardDiffExt.jl
Outdated
|
|
||
| isfresh = !isnothing(A) | ||
| precsisfresh = !reuse_precs && (isfresh || !isnothing(p)) | ||
| isfresh |= cache.isfresh |
Member
There was a problem hiding this comment.
DualLinearCache doesn't have a field isfresh. Should this be cache.linear_cache.isfresh ?
Member
|
I forgot that I have to hit submit review for my comments to show up... |
ChrisRackauckas-Claude
pushed a commit
to ChrisRackauckas-Claude/LinearSolve.jl
that referenced
this pull request
Dec 8, 2025
This adds the missing reinit! method for the DualLinearCache type, which is needed when using ForwardDiff with LinearSolve and wanting to update the cache values without creating a new cache. The implementation directly mutates the cache fields (following the same pattern as the regular LinearCache reinit! method) rather than using the setX! helper functions. Closes SciML#836 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
5 tasks
ChrisRackauckas
approved these changes
Dec 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
contributor guidelines, in particular the SciML Style Guide and
COLPRAC.
Additional context
This is an attempt to implement the missing reinit! metod for the dual cache.
I am however unsure if this is correct, at least the test works.