leanrows@0.1.3, leanmark@0.2.0: Add manifests - #18495
Conversation
📝 WalkthroughWalkthroughAdds Scoop manifests for LeanMark 0.2.0 and LeanRows 0.1.3. Each manifest defines package metadata, a Windows 64-bit download, SHA-256 verification, installation cleanup, an executable shortcut, GitHub version checking, and versioned autoupdate URLs. The LeanMark manifest also includes a WebView2 runtime note. Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related PRs
Suggested labels: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@bucket/leanmark.json`:
- Around line 2-5: Create a package-request issue for LeanMark and LeanRows,
verify both package criteria, and add the issue number or URL to the PR
description rather than either manifest description. For bucket/leanmark.json
lines 2-5 and bucket/leanrows.json lines 2-5, no direct manifest change is
required; include both packages in the same request or link each package’s
separate request.
- Line 21: Update the LeanMark manifest’s dependencies by adding the Microsoft
Edge WebView2 package under the suggest section using the extras/webview2
identifier. If this is a new manifest, include the provided Scoop
package-request issue link in the description or PR body.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro Plus
Run ID: c4f3c5a4-921b-46a6-aa4a-4435fbc7e993
📒 Files selected for processing (2)
bucket/leanmark.jsonbucket/leanrows.json
| "version": "0.2.0", | ||
| "description": "Read-only Markdown viewer with offline GitHub-flavored Markdown and Mermaid rendering", | ||
| "homepage": "https://abooodbah.github.io/leanmark/", | ||
| "license": "MIT", |
There was a problem hiding this comment.
📐 Maintainability & Code Quality | 🟠 Major | ⚡ Quick win
Link a package-request issue in the PR description.
Both files are newly added manifests. Create a package-request issue, verify the package criteria, and add its number or URL to the PR description. Verify that each package is widely used, has a stable release, and has an English interface or documentation. Do not add the issue reference to either manifest description.
bucket/leanmark.json#L2-L5: link the package-request issue in the PR description for LeanMark.bucket/leanrows.json#L2-L5: include LeanRows in the same issue or link its own package-request issue.
Create the request at https://github.com/ScoopInstaller/Extras/issues/new?labels=package-request&template=package-request.yml&title=%5BRequest%5D%3A+.
See https://github.com/ScoopInstaller/.github/blob/main/.github/CONTRIBUTING.md and https://github.com/ScoopInstaller/Scoop/wiki/App-Manifests.
As per path instructions, new manifests require a package-request issue in the PR description. Based on learnings, do not put that reference in description.
📍 Affects 2 files
bucket/leanmark.json#L2-L5(this comment)bucket/leanrows.json#L2-L5
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@bucket/leanmark.json` around lines 2 - 5, Create a package-request issue for
LeanMark and LeanRows, verify both package criteria, and add the issue number or
URL to the PR description rather than either manifest description. For
bucket/leanmark.json lines 2-5 and bucket/leanrows.json lines 2-5, no direct
manifest change is required; include both packages in the same request or link
each package’s separate request.
Sources: Path instructions, Learnings
|
https://github.com/ScoopInstaller/.github/blob/main/.github/CONTRIBUTING.md
|
|
To add a new package to this bucket, please follow the standard way to create a package request issue first and link it to your PR. When creating a package request, you can check the criteria for a package to be accepted in this bucket, which can help you determine whether your PR is likely to be approved. The information provided in the issue can also help maintainers quickly get the necessary details.
|
|
It appears that this package doesn't fully meet the essential criteria. Please feel free to reopen this PR once it fully meets the criteria, or consider creating your own bucket instead. |
Adds two small, MIT-licensed, portable Windows viewers.
leanrows — read-only viewer for large CSV/TSV/JSONL/log files. Indexes progressively and materializes only the rows in the viewport, so peak memory is governed by window size rather than file size. Measured: a 1.53 GB, 20,000,001-row CSV opens at 18.4 MB peak working set. 546 KB executable, no runtime dependency.
Homepage: https://abooodbah.github.io/leanrows/
leanmark — read-only Markdown viewer rendering GFM and Mermaid entirely offline via the system web runtime (WebView2), no bundled Chromium.
Homepage: https://abooodbah.github.io/leanmark/
Both manifests were checked locally: hashes verified against the published release archives,
extract_dirandbinpaths confirmed against the archive contents, andcheckver/autoupdatewired to the GitHub releases with sidecar .sha256 files.pre_installstrips the bundled per-user installer scripts so Scoop manages the install.Related existing manifests in this bucket: tad, smoothcsv, klogg, glogg.