feat(RN): replace addEventListener with callback args#119
Merged
kieran-osgood-shopify merged 3 commits intoMay 22, 2026
Merged
Conversation
This was referenced May 14, 2026
Contributor
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
11 tasks
fe4bbe0 to
866347c
Compare
11 tasks
This was referenced May 15, 2026
11 tasks
ca7804f to
27e1a45
Compare
866347c to
86cefb5
Compare
27e1a45 to
df3847b
Compare
86cefb5 to
fc3c557
Compare
fc3c557 to
3fe052f
Compare
be2d4ac to
054ed77
Compare
538a16b to
0967be1
Compare
11 tasks
bb2ece5 to
f782d21
Compare
11 tasks
f782d21 to
2a42f7e
Compare
11 tasks
2a42f7e to
d949cb6
Compare
d949cb6 to
3921fb8
Compare
3921fb8 to
16be541
Compare
kiftio
reviewed
May 22, 2026
16be541 to
5b6cd97
Compare
kiftio
approved these changes
May 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

What changes are you making?
The current React Native API exposes
checkout.addEventListener(event, callback)for close, error, and geolocationRequest.It operates on a "global" singleton pattern, and works well for responding to things like AppState or Keyboard, but not so much on the instances of
AcceleratedCheckoutButtonsor theShopifyCheckoutcomponent.Removing it in this PR leads us towards the future state API in upstack PR's
How to test
Before you merge
Important
platforms/swift/README.mdand/orplatforms/android/README.md)Releasing a new Swift version?
ShopifyCheckoutKit.podspecplatforms/swift/Sources/ShopifyCheckoutKit/ShopifyCheckoutKit.swiftplatforms/swift/CHANGELOG.mdplatforms/swift/README.md(major version only)Releasing a new Android version?
versionNameinplatforms/android/lib/build.gradleplatforms/android/CHANGELOG.mdplatforms/android/README.mdTip
See the Contributing documentation for the full release process per platform.