Skip to content

Rename Dependency Review Action to Dependency Split Action - #2129

Open
damn-am-star wants to merge 441 commits into
Shopify:no-freeze-static-environmentfrom
damn-am-star:damn-am-star-patch-1
Open

damn-am-star wants to merge 441 commits into
Shopify:no-freeze-static-environmentfrom
damn-am-star:damn-am-star-patch-1

Conversation

@damn-am-star

Copy link
Copy Markdown

No description provided.

aswamy and others added 27 commits March 19, 2026 15:29
Update ruby/setup-ruby to v1.295.0 for ubuntu-24.04 support
Add bare-bracket rejection to Parser#expression in strict2 mode, so that
`['var']` is disallowed and `self['var']` is the required syntax.

- Add `Expression::SELF` constant ('self')
- Add `Parser#reject_bare_brackets` option, checked in `expression`
- Add `ParseContext#reject_bare_brackets?` and `force_reject_bare_brackets`
- Add `VariableLookupDrop` for `self['var']` scope-chain lookups
- Add `Variable#==` for rewriter state comparison
- Update `Context#find_variable` to return `VariableLookupDrop` for `self`

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Store @is_for_loop during parsing so consumers can determine the
with/for keyword from the AST instead of re-parsing raw markup.
Matches the existing pattern in the Render tag.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Both tags previously used only regex (VariableSignature) to validate
variable names, which allowed invalid identifiers like (a(b(c) and
[x.y] in all parse modes.

- assign: strict2_parse uses Parser to validate the LHS as a valid
  identifier before delegating RHS to Variable
- capture: strict2_parse uses Parser to validate the variable name
  as a valid identifier
- Both tags now include ParserSwitching and dispatch through
  strict_parse_with_error_mode_fallback
- Lax mode is unchanged — invalid names are still accepted

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Skip slow test raising many exceptions on non-CRuby
Both tags previously accepted any string as a variable name via
`markup.strip`. Now they use `parse_with_selected_parser` and validate
the variable name with `p.consume(:id)` in strict2 mode.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Reject bare-bracket syntax in strict2 and introduce `self` keyword
Add strict2_parse to assign and capture tags
Add strict2_parse to increment and decrement tags
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
…r-message

Remove "strict2" from bare bracket error message
Keep the historical blank-body inline-error suppression for lax and strict parse modes, but stop suppressing the rendered error text when the template was parsed in strict2. Raised-error rendering continues to raise in all modes.

Store the resolved template error mode on the render context while a template renders so BlockBody can distinguish strict2 from compatibility modes when deciding whether a blank tag should hide inline error text.

Add integration coverage for lax/strict suppression, strict2 non-suppression across blank body forms, nonblank bodies, and raised-error behavior.
* Pin Liquid specs to the merged self-drop tests

Assisted-By: devx/b8d3b9bd-01a3-41b1-90f8-632318b798e4

* Align blank-body error tests with strict2 behavior

Assisted-By: devx/b8d3b9bd-01a3-41b1-90f8-632318b798e4

* Check Drop symbol safety without counting JIT metadata

Assisted-By: devx/b8d3b9bd-01a3-41b1-90f8-632318b798e4

* Update liquid-spec to the latest main revision

Assisted-By: devx/b8d3b9bd-01a3-41b1-90f8-632318b798e4
Assisted-By: devx/b8d3b9bd-01a3-41b1-90f8-632318b798e4
@damn-am-star
damn-am-star changed the base branch from main to no-freeze-static-environment October 9, 2026 04:32

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.