Rails 7.0 support and drop older railses

[casperisfine]

As well as remove unused features (e.g. read only).

This if merged should be a major bump.

[rafaelfranca]

What happens if someone report a bug with Rails 6.1 with the actual released branch? We create a release branch for the current major?

[casperisfine]

What happens if someone report a bug with Rails 6.1 with the actual released branch?

We can maintain a 2.x-stable branch. But based on the download numbers, I doubt there's many non-Shopify users out there: https://rubygems.org/gems/memcached_store, maybe a few but with the state of memcached and memcached_store I'd be really surprised.

[etiennebarrie]

LGTM

[etiennebarrie]

We should remove it since we don't support it.

[casperisfine]

Good catch.

[shioyama]

This LGTM but I haven't been able to fully follow the corresponding Rails changes, so I'm holding off reviewing yet. I'll focus on decoupling our code from this gem altogether where it makes sense so changes here have less impact.

[shioyama]

I'm just commenting for now, I'll try creating a failing test to check what I commented.

[shioyama]

I think this will break raw values read back from the cache.

Currently a raw value written to the cache with Rails.cache.write("foo", "bar", raw: true) can be read back with just Rails.cache.read("foo") (no raw: true), but with this change this won't work unless you pass raw: true.

[casperisfine]

Yes, I broke this knowingly.

[shioyama]

This fails:

  def test_raw
    assert @cache.write("foo", "1", raw: true)
    assert_equal "1", @cache.read("foo")                                                                                                                          
  end

It seems like all tests on raw values now pass raw: true to read / fetch, so maybe this is intentional? But if so it will break a lot of stuff, and I'm not even sure how it could be handled in contexts where you're not sure if the stored value is raw or not.

[shioyama]

Approving since the breaking change is known, although I'm not sure how it should be handled.

[casperisfine]

if so it will break a lot of stuff,

You think? Shouldn't be too hard to track down no?