Skip to content

Fixing npm audit - #15

Merged
pr0uxx merged 4 commits into
mainfrom
fix/failed-builds
Sep 18, 2026
Merged

pr0uxx merged 4 commits into
mainfrom
fix/failed-builds

Conversation

@pr0uxx

@pr0uxx pr0uxx commented Sep 18, 2026

Copy link
Copy Markdown
Contributor

Summary

Previous builds were failing at npm audit signatures.

After investigation, this was found to be caused by package-lock.json being generated over stale node_modules causing npm audit validate to attempt resolution of package versions that don't exist.

I have added npm audit validate to the local validate:package:skip-reachability script to guard against this issue arising during release again.

"baseline-browser-mapping": "^2.11.24" has been added as per recommendation by socket optimize.

.idea has been added to prevent users of jet brains packages accidentally releasing config files with the published package

Usual maintenance also present:

  • version bumped to next patch
  • package-lock.json updated
  • socketsecurity pin updated to latest compatible version

Type Of Change

  • Bug fix
  • New feature
  • Refactor
  • Performance improvement
  • Documentation update
  • CI/CD or build change
  • Dependency update

Activities Checklist

Code Quality

  • I reviewed my own code.
  • I kept changes focused and removed dead code.
  • I followed repository conventions and naming.
  • I added or updated comments where behavior is non-obvious.

Testing And Validation

  • I ran npm run validate:package.
  • I added or updated tests for the changed behavior.
  • I verified no existing tests regressed.

Coverage

  • Coverage impact is acceptable for this change.
  • If coverage decreased, I explained why in this PR.

Security And Safety

  • I did not introduce secrets, tokens, or credentials.
  • Inputs are validated and error handling is appropriate.
  • Dependency changes were reviewed for risk.

Documentation

  • I updated README/docs when behavior or usage changed.
  • I updated examples if needed.

Release Impact

  • This change is backward compatible.
  • If breaking, I documented migration steps.
  • I considered versioning impact (patch/minor/major).

script runs npm audit validate and outputs a recommendation message if it fails. This is to prevent future issues with build pipeline failing due to package-lock being generated from stale node_modules
Prevents .idea files leaking into package from users using jet brains IDEs
@pr0uxx
pr0uxx requested review from Jonny Pound (JonnyPound90) and a lite review from Copilot September 18, 2026 10:20
@socket-security

Copy link
Copy Markdown

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Updatedbaseline-browser-mapping@​2.11.21 ⏵ 2.11.2482 +1100100 +196100

View full report

@socket-security

Copy link
Copy Markdown

Warning

Review the following alerts detected in dependencies.

According to your organization's Security Policy, it is recommended to resolve "Warn" alerts. Learn more about Socket for GitHub.

Action Severity Alert  (click "▶" to expand/collapse)
Warn Low
Unmaintained: npm is-interactive was last published 5 years ago

Last Publish: 5/3/2021, 8:19:09 PM

From: package-lock.json → npm/typia@12.1.1 → npm/is-interactive@1.0.0

ℹ Read more on: This package | This alert | What are unmaintained packages?

Next steps: Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support@socket.dev.

Suggestion: Package should publish periodic maintenance releases if they are maintained, or deprecate if they have no intention in further maintenance.

Mark the package as acceptable risk. To ignore this alert only in this pull request, reply with the comment @SocketSecurity ignore npm/is-interactive@1.0.0. You can also ignore all packages with @SocketSecurity ignore-all. To ignore an alert for all future pull requests, use Socket's Dashboard to change the triage state of this alert.

Warn Low
Unmaintained: npm path-parse was last published 5 years ago

Last Publish: 5/25/2021, 12:57:37 PM

From: package-lock.json → npm/ts-patch@4.0.1 → npm/path-parse@1.0.7

ℹ Read more on: This package | This alert | What are unmaintained packages?

Next steps: Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support@socket.dev.

Suggestion: Package should publish periodic maintenance releases if they are maintained, or deprecate if they have no intention in further maintenance.

Mark the package as acceptable risk. To ignore this alert only in this pull request, reply with the comment @SocketSecurity ignore npm/path-parse@1.0.7. You can also ignore all packages with @SocketSecurity ignore-all. To ignore an alert for all future pull requests, use Socket's Dashboard to change the triage state of this alert.

View full report

@github-actions

Copy link
Copy Markdown

🟢 Coverage Report

Metric Coverage Threshold Covered
Statements 95.3% 95% 508/533
Branches 87.98% 85% 337/383
Functions 100% 99% 125/125
Lines 95.38% 95% 496/520

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@pr0uxx pr0uxx self-assigned this Sep 18, 2026
@pr0uxx
pr0uxx merged commit 6e92895 into main Sep 18, 2026
7 of 9 checks passed
@pr0uxx
pr0uxx deleted the fix/failed-builds branch September 18, 2026 10:31
@pr0uxx pr0uxx mentioned this pull request Sep 18, 2026
24 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants