Skip to content

LAB-2143 - Fix CI checkout ordering and bump alpha version - #2

Merged
pr0uxx merged 1 commit into
mainfrom
LAB-2143-LogEngine-extremely-decoupled-from-shield
Jul 30, 2026
Merged

pr0uxx merged 1 commit into
mainfrom
LAB-2143-LogEngine-extremely-decoupled-from-shield

Conversation

@pr0uxx

@pr0uxx pr0uxx commented Jul 30, 2026 •

Copy link
Copy Markdown
Contributor

Summary

Remove background execution from the checkout step in Build.yml so local composite actions only run after repository files are available. Also update the package version to 0.0.3-alpha1 in package metadata.

Type Of Change

  • Bug fix
  • New feature
  • Refactor
  • Performance improvement
  • Documentation update
  • CI/CD or build change
  • Dependency update

Activities Checklist

Code Quality

  • I reviewed my own code.
  • I kept changes focused and removed dead code.
  • I followed repository conventions and naming.
  • I added or updated comments where behavior is non-obvious.

Testing And Validation

  • I ran npm run validate:package.
  • I added or updated tests for the changed behavior.
  • I verified no existing tests regressed.

Coverage

  • Coverage impact is acceptable for this change.
  • If coverage decreased, I explained why in this PR.

Security And Safety

  • I did not introduce secrets, tokens, or credentials.
  • Inputs are validated and error handling is appropriate.
  • Dependency changes were reviewed for risk.

Documentation

  • I updated README/docs when behavior or usage changed.
  • I updated examples if needed.

Release Impact

  • This change is backward compatible.
  • If breaking, I documented migration steps.
  • I considered versioning impact (patch/minor/major).

Linked Work

Notes For Reviewers

  • Areas that need extra attention:
  • Follow-up work (if any): I hate this part of workflows, when they don't work and you keep having to make PRs to fix them.

Remove background execution from the checkout step in Build.yml so local composite actions only run after repository files are available. Also update the package version to 0.0.3-alpha1 in package metadata.
@pr0uxx pr0uxx self-assigned this Jul 30, 2026
Copilot AI review requested due to automatic review settings July 30, 2026 07:42

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes CI step ordering in Build.yml by ensuring repository checkout completes before invoking a local composite action, and bumps the NPM package version to an alpha prerelease (0.0.3-alpha1) across package metadata.

Changes:

  • Make the actions/checkout step run synchronously (remove background execution) to ensure local composite actions can be read from the checked-out workspace.
  • Add clarifying comments explaining why checkout must not run in the background.
  • Update package.json and package-lock.json version to 0.0.3-alpha1.

Reviewed changes

Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments.

File Description
package.json Bumps package version to the alpha prerelease.
package-lock.json Keeps lockfile version in sync with package.json.
.github/workflows/Build.yml Ensures checkout completes before local composite actions run by removing background execution from checkout.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@github-actions

Copy link
Copy Markdown

🟢 Coverage Report

Metric Coverage Threshold Covered
Statements 96.45% 95% 381/395
Branches 88.85% 85% 255/287
Functions 100% 99% 106/106
Lines 96.6% 95% 370/383

@pr0uxx
pr0uxx merged commit 990c7c0 into main Jul 30, 2026
7 of 9 checks passed
@pr0uxx
pr0uxx deleted the LAB-2143-LogEngine-extremely-decoupled-from-shield branch July 30, 2026 07:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants