Repository navigation
Return ssh url for sessions with ssh frontend - #1467
Merged
Merged
Conversation
Contributor
|
You can access the deployment of this PR at https://renku-ci-ds-1467.dev.renku.ch |
Coverage Report for CI Build 36986808718Warning No base build found for commit Coverage: 85.275%Details
Uncovered Changes
Coverage RegressionsRequires a base build to compare against. How to fix this → Coverage Stats
💛 - Coveralls |
eikek
force-pushed
the
eikek/feat/session-ssh-url
branch
from
October 1, 2026 08:16
f184776 to
20a5b29
Compare
eikek
marked this pull request as ready for review
October 1, 2026 09:30
sgaist
approved these changes
Oct 1, 2026
SalimKayal
force-pushed
the
salimkayal/feat/ssh-mounts-gated-by-frontend
branch
from
October 1, 2026 14:43
8635fed to
6a0a2e3
Compare
SalimKayal
force-pushed
the
eikek/feat/session-ssh-url
branch
from
October 1, 2026 15:05
20a5b29 to
6850c62
Compare
SalimKayal
force-pushed
the
salimkayal/feat/ssh-mounts-gated-by-frontend
branch
from
October 1, 2026 15:12
6a0a2e3 to
dbd81e8
Compare
SalimKayal
force-pushed
the
eikek/feat/session-ssh-url
branch
from
October 1, 2026 15:12
6850c62 to
aa2336d
Compare
This was referenced Oct 1, 2026
olevski
force-pushed
the
salimkayal/feat/ssh-mounts-gated-by-frontend
branch
from
October 1, 2026 15:53
dbd81e8 to
a37355d
Compare
SalimKayal
force-pushed
the
eikek/feat/session-ssh-url
branch
from
October 1, 2026 16:22
aa2336d to
7e65024
Compare
SalimKayal
force-pushed
the
salimkayal/feat/ssh-mounts-gated-by-frontend
branch
from
October 1, 2026 16:29
a37355d to
c16e1d8
Compare
SalimKayal
force-pushed
the
eikek/feat/session-ssh-url
branch
from
October 1, 2026 16:29
7e65024 to
b2de5e4
Compare
eikek
force-pushed
the
eikek/feat/session-ssh-url
branch
from
October 1, 2026 16:36
b2de5e4 to
77a33de
Compare
Base automatically changed from
salimkayal/feat/ssh-mounts-gated-by-frontend
to
salimkayal/feat/ssh-keys
October 1, 2026 21:18
eikek
force-pushed
the
eikek/feat/session-ssh-url
branch
2 times, most recently
from
October 2, 2026 06:19
06e544c to
abb81a3
Compare
olevski
requested changes
Oct 2, 2026
olevski
left a comment
olevski
left a comment
Member
There was a problem hiding this comment.
One small change required Eike. It got lost in the rebasing.
eikek
force-pushed
the
eikek/feat/session-ssh-url
branch
from
October 2, 2026 07:00
abb81a3 to
2c38f4e
Compare
olevski
approved these changes
Oct 2, 2026
olevski
force-pushed
the
salimkayal/feat/ssh-keys
branch
from
October 2, 2026 07:51
e40dd91 to
fa1a071
Compare
eikek
force-pushed
the
eikek/feat/session-ssh-url
branch
from
October 2, 2026 07:53
2c38f4e to
2de5667
Compare
eikek
force-pushed
the
eikek/feat/session-ssh-url
branch
from
October 2, 2026 08:55
57eb405 to
b4da3a6
Compare
Contributor
|
Tearing down the temporary RenkuLab deployment for this PR. |
olevski
added a commit
that referenced
this pull request
Oct 13, 2026
* feat(users): store ssh keys (#1442) * feat(users): add /user/ssh_keys CRUD API (#1444) * feat: proxy api for ssh keys (#1446) * feat(notebooks): configure proxy-to-session key secret names (#1452) * feat: Add frontend variant as session label (#1455) * feat(notebooks): mount proxy-to-session keys only for ssh frontends (#1458) * feat: return ssh url for sessions with ssh frontend (#1467) Co-authored-by: Tasko Olevski <16360283+olevski@users.noreply.github.com> Co-authored-by: boucherjeanphi <49230173+boucherjeanphi@users.noreply.github.com> Co-authored-by: eikek <701128+eikek@users.noreply.github.com> Co-authored-by: Eike Kettner <eike.kettner@sdsc.ethz.ch>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For sessions that use the "ssh frontend", the session url should denote the public interface, like
ssh://<session-name>@<public-hostname>[:port].When a session is accessed via ssh, there is no ingress and no (status) url derived in amalthea. Then the crafted ssh url is returned as the session url to clients.
PR Stack
/deploy #notest extra-values=sshProxy.enabled=true,dataService.imageBuilders.enabled=true,dataService.imageBuilders.strategyName=renku-buildpacks-v3,dataService.imageBuilders.outputImagePrefix=harbor.dev.renku.ch/renku-build/,dataService.imageBuilders.nodeSelector.renku.io/node-purpose=user,dataService.imageBuilders.tolerations[0].effect=NoSchedule,dataService.imageBuilders.tolerations[0].key=renku.io/dedicated,dataService.imageBuilders.tolerations[0].operator=Equal,dataService.imageBuilders.tolerations[0].value=user renku=build/renku-ssh-proxy renku-ui=lorenzo/ssh-keys-required