Add frontend variant as session label

[eikek]

Add the frontend variant to the session details. It will be also added as a label to the session k8s resource. This is later used to decide whether ssh specific configuration is added to the resource.

---

PR Stack

• feat: add support for ssh pubkeys storing / validating / retrieving  #1441
  • Add frontend variant as session label #1455 ◀️ this PR
    • feat(notebooks): mount proxy-to-session keys only for ssh frontends #1458
      • Return ssh url for sessions with ssh frontend #1467

---

/deploy #notest extra-values=sshProxy.targetUser=renku,sshProxy.targetPort=2222,dataService.imageBuilders.enabled=true,dataService.imageBuilders.strategyName=renku-buildpacks-v3,dataService.imageBuilders.outputImagePrefix=harbor.dev.renku.ch/renku-build/,dataService.imageBuilders.nodeSelector.renku.io/node-purpose=user,dataService.imageBuilders.tolerations[0].effect=NoSchedule,dataService.imageBuilders.tolerations[0].key=renku.io/dedicated,dataService.imageBuilders.tolerations[0].operator=Equal,dataService.imageBuilders.tolerations[0].value=user amalthea-sessions=salimkayal/feat/2222-service-in-ssh-sessions renku-ui=lorenzo/ssh-keys-required renku=eikek/ssh-buildpack-update

[coveralls]

Coverage Report for CI Build 36882444583

Warning

No base build found for commit 60fa4a8 on salimkayal/feat/ssh-keys.
Coverage changes can't be calculated without a base build.
If a base build is processing, this comment will update automatically when it completes.

Coverage: 85.29%

Details

• Patch coverage: 1 uncovered change across 1 file (56 of 57 lines covered, 98.25%).

Uncovered Changes

File	Changed	Covered	%
components/renku_data_services/notebooks/core_sessions.py	6	5	83.33%
Total (4 files)	57	56	98.25%

Coverage Regressions

Requires a base build to compare against. How to fix this →

---

Coverage Stats

Relevant Lines:	34739
Covered Lines:	29629
Line Coverage:	85.29%
Coverage Strength:	1.48 hits per line

---

💛 - Coveralls

[RenkuBot]

You can access the deployment of this PR at https://renku-ci-ds-1455.dev.renku.ch

[leafty]

See: SwissDataScienceCenter/amalthea#1230 (comment)

This is bad design: it is non-extensible and non-flexible. Add SSH into the amalthea spec.

[leafty]

See: SwissDataScienceCenter/amalthea#1230 (comment)

This is bad design: it is non-extensible and non-flexible. Add SSH into the amalthea spec.

Also, to be clear: the issue is not adding a new label, it is that the AmaltheaSession behavior should be dictated by the spec and not labels/annotations.

[eikek]

See: SwissDataScienceCenter/amalthea#1230 (comment)
This is bad design: it is non-extensible and non-flexible. Add SSH into the amalthea spec.

Also, to be clear: the issue is not adding a new label, it is that the AmaltheaSession behavior should be dictated by the spec and not labels/annotations.

We now don't use the label in amalthea. We return a ssh url in the session responso to transport the details for how to connect. #1467

The labels do not drive the behaviour of amalthea anymore. They are there for information purposes only. Subsequent PRs will provide information on how to connect to the SSH server. So all the comments have been addressed.

[RenkuBot]

Tearing down the temporary RenkuLab deployment for this PR.