Skip to content

fix(site): correct landing-page claims and render README tables on gallery pages - #208

Merged
TMHSDigital merged 1 commit into
mainfrom
fix/site-review-high-items
Sep 22, 2026
Merged

TMHSDigital merged 1 commit into
mainfrom
fix/site-review-high-items

Conversation

@TMHSDigital

Copy link
Copy Markdown
Owner

Summary

A review of the live Pages site found the landing page naming Blender 5.1 as the primary target and calling every render a CI artifact, an empty Rules "Scope" column, invisible keyboard focus on render cards, and every gallery README table (182 of them) printing as raw | a | b | text. This fixes those plus two small copy/link errors. No Blender content changes.

Type

  • feat
  • fix — correction to existing content (site generator + landing template)
  • docs / chore / ci / refactor

Changes

Landing page (scripts/site/template.html.j2, scripts/site/build_site.py)

  • Versions read 5.2 LTS / 4.5 LTS (matches the blender-smoke.yml PR matrix); no 5.1 claims remain.
  • "Every render here is a CI artifact" → "Every render here is code that runs". CI renders only swatch-grid (tests/smoke/catalog.json); gallery stills are committed.
  • Rules Scope column populated: the parser stopped reading at description (always the first key) and couldn't read the YAML globs list.
  • .render-card:focus-visible now shows the selection outline (it was overridden by the transparent base outline).
  • Showcase CTA links to gallery/#tag=showcase (the gallery already supports the hash filter).
  • Rules copy says they load when a matching file is open, not "always-on"; templates sentence lists all three.
  • Stats HUD numbers rendered server-side (were 0 for crawlers/no-JS); Examples counter uses plugin.json (59, matching README).

Gallery (scripts/build_gallery.py, 80 regenerated pages)

  • README converter gains pipe tables (<th scope="col">, horizontal scroll wrapper), *emphasis*, ordered lists, and inline images (rendered as links). A README's leading ![…](preview.webp) is dropped because it duplicates the page hero.

Evidence

  • live-run-proven (local, no Blender involved): rebuilt the landing page with build_site.py and the gallery with build_gallery.py, and served docs/ locally with Playwright.
    • Rendered pages: 0 raw pipe paragraphs remain (was 182). 182 <table>, 67 <em>, 1 <ol>, 0 stray asterisks outside code.
    • Rules Scope shows **/*.py ×8 and **/__init__.py, **/blender_manifest.toml.
    • Tabbing to a render card yields computed outline rgb(255, 140, 25).
    • No horizontal overflow at 375px.
  • Idempotence: a second build_gallery.py run produces no further diff.
  • Diff: no line removed beyond the intended ones (raw table rows, asterisk emphasis, preview images, one CSS rule).
  • inspection-only: Blender smoke is unaffected; no example scripts or catalog rows changed.

Checklist

  • Explicit paths only.
  • Counts unchanged (no content added/removed).
  • Manifest untouched.
  • No new check added.
  • DCO Signed-off-by: present.
  • No credentials, emails, or local paths.

Test plan

python scripts/site/build_site.py --repo-root . --out docs and python scripts/build_gallery.py, then view / and /gallery/anvil/, /gallery/crate-stack/, /gallery/armature-bend/ at 1440px and 375px.

Not in this PR (from the same review)

  • Whether docs/gallery/contact-sheets/ (3.4 MB), technical-audit.md, new-example-prompt.md, VISUAL-STYLE.md, DESIGN_NOTES.md should stay publicly served — owner decision.
  • Mid-sentence truncation of skill/rule descriptions; 28-card showcase wall; gallery a11y (card aria-label hides alt text, zoom overlay isn't a modal dialog); no custom 404; color-scheme: dark.

🤖 Generated with Claude Code

…llery pages

A review of the live Pages site found the landing page naming Blender 5.1
as the primary target and calling every render a CI artifact, when CI
checks 5.2 LTS and 4.5 LTS and renders only swatch-grid. The Rules table's
Scope column was empty because the parser stopped at `description`, and
render cards showed no keyboard focus ring. On the gallery, the README
converter had no table, emphasis, ordered-list or image support, so all
182 budget tables printed as raw pipe text.

- template: 5.2 LTS / 4.5 LTS wording, accurate render claim, visible
  focus on render cards, showcase CTA links to #tag=showcase, rules and
  templates copy match the repo, stats rendered server-side
- build_site: parse `globs` YAML lists for the rule scope column; HUD
  example count includes check-only examples (plugin.json)
- build_gallery: pipe tables, *emphasis*, ordered lists, inline images;
  drop the README's own preview image, which duplicates the hero

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Signed-off-by: TMHSDigital <154358121+TMHSDigital@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant