feat(search): find a value in every table of a database by datlechin · Pull Request #3737 · TableProApp/TablePro

datlechin · 2026-10-21T02:24:23Z

Summary

Database > Search Database…, plus Search Database… / Search Schema… on a sidebar database or schema row (hierarchical schema rows too), open a sheet that finds which tables hold a value.
Sheet: value, match mode (Contains, Matches Exactly, Starts With), Match Case (dimmed where the collation decides, as in the filter bar), Include binary columns, and a checklist of tables grouped by schema.
Text columns always join. Number, date, timestamp and UUID columns join when the value parses as that type, as =. Binary only when ticked. A column joins only where the engine can compare it, since one bad predicate fails the table.
One SELECT per table on a pooled, cancellable read with the connection's query timeout: a CASE WHEN flag per searched column, conditions from FilterSQLGenerator, at most 1,001 rows through SQLRowLimitClause.
Progress counts tables. Stop aborts the statement in flight and keeps the results. A table that errors is listed with the error and the search goes on.
Results show each table's matching columns and row count (1,000+ past the cap). Open puts the table in a new tab filtered with Match any over the matched columns, or every searched column when capped.
The session stays on the window, so the sheet reopens on its results.
Not offered on MongoDB, Redis, Cassandra, ScyllaDB, DynamoDB or other engines without SQL, a row limit and Match any.
The value is not bound as a parameter: the search uses the filter bar's escaped conditions, so the tab runs the same predicate.
FilterSQLGenerator, also used by the filter bar and row counts:
- Trino: case-insensitive regex as REGEXP_LIKE(col, '(?i)…'); its REGEXP_LIKE takes two arguments. The five pinned Trino cases in FilterSQLGeneratorCaseSensitivityTests are updated.
- SQL Server: [ in a LIKE value is escaped.
- Oracle family: date and timestamp values compare as ANSI DATE / TIMESTAMP literals instead of strings read through NLS_DATE_FORMAT.
ColumnTypeSQLQuoting.hasEqualityOperator takes the engine family: SQL Server TEXT has no =. The cell Filter menu passes it, so it no longer offers = on such a column.
Docs: docs(features): document Search Database docs#92.

Test plan

DatabaseSearchColumnPlannerTests: which columns join per type, mode and engine family.
DatabaseSearchQueryTests: flags, OR, cap + 1 on LIMIT and OFFSET/FETCH engines, escaping, cap reporting, the tab's filter state.
DatabaseSearchSessionTests: preselection, order, a failing table, Stop at the next table, Edit Search fencing a late read.
DatabaseSearchResultOpeningTests: the payload a result opens, and the session kept per scope.
FilterSQLGeneratorColumnTypeTests, FilterSQLGeneratorCaseSensitivityTests, CellFilterMenuBuilderTests: the generator and equality fixes.
DatabaseTreeMenuSpecTests, MainMenuBuilderTests: the commands and their gates.
SearchDatabaseUITests: on the fixture, search "brook", open the result, the artist tab shows only Brook.

Fixes #3601

…add the strings

… Server, use ANSI dates on Oracle

…ase where collation decides

…re the scan

…base # Conflicts: # apple/TablePro/Core/Utilities/SQL/ColumnTypeSQLQuoting.swift # apple/TablePro/Resources/Localizable.xcstrings

…base # Conflicts: # apple/TablePro/Views/Main/MainContentCoordinator.swift

…base

J2TeamNNL

Code review: 7 findings, inline.

J2TeamNNL · 2026-10-21T09:27:43Z

+        guard characters.count == 10 else { return false }
+        return isCalendarDate(characters)
+    }
+


isDateTime accepts 1 to 9 fractional digits and a space separator for every engine. SQL Server datetime rejects more than 3 fractional digits and reads the space form by session language. Searching 2024-01-05 10:00:00.1234567 would fail the whole table query, so no column of that table gets searched.

J2TeamNNL · 2026-10-21T09:27:43Z

+    }
+
+    // MARK: - Catalog
+


loadTablesIfNeeded returns once the catalog is loaded, and the coordinator caches the session. After a table is dropped or created, reopening the sheet shows the old list: new tables are never searched and dropped ones come back as failed.

J2TeamNNL · 2026-10-21T09:27:43Z

+        let namespaces = try await ObjectCopyCatalog(manager: manager).namespaces(of: endpoint, connection: connection)
+        let systemSchemas = Set(PluginManager.shared.systemSchemaNames(for: connection.type))
+        var found: [DatabaseSearchTarget] = []
+        for namespace in namespaces {


tables() throws on the first schema whose fetchTables fails (no USAGE privilege, broken synonym). The catalog becomes failed and no table in any other schema can be searched.

J2TeamNNL · 2026-10-21T09:27:43Z

+        case .null:
+            return false
+        case .bytes(let data):
+            return data.contains { $0 != 0 }


isSet treats any non-zero byte in .bytes as set. A driver that returns the flag 0 as ASCII 0 (0x30) makes every column look matched, so the tab filters on columns that do not match.

J2TeamNNL · 2026-10-21T09:27:43Z

+        )
+        databaseSearchSession = session
+        return session
+    }


openDatabaseSearchResult always calls session.stop(). Double-clicking a result while the search runs cancels the remaining tables, though the footer Open button is hidden during a run.

J2TeamNNL · 2026-10-21T09:27:43Z

+            ? String(format: String(localized: "%@ row"), count)
+            : String(format: String(localized: "%@ rows"), count)
+    }
+


The '%1$@ of %2$@ tables' formatting is duplicated in DatabaseSearchSummary.progress and DatabaseSearchSession.selectionSummary. A change to one leaves the other behind.

J2TeamNNL · 2026-10-21T09:27:43Z

+        guard characters.count >= 19, characters[10] == " " || characters[10] == "T",
+              [11, 12, 14, 15, 17, 18].allSatisfy(isDigit), characters[13] == ":", characters[16] == ":"
+        else { return nil }
+        let fraction = characters.dropFirst(19)


oracleTemporalLiteral turns every ANSI-shaped value on an Oracle date column into DATE '...', so = 2024-01-05 matches only midnight rows. This also changes the existing filter bar, not only search.

J2TeamNNL · 2026-10-21T09:28:14Z

Follow-up on the review above.

Fixed in J2TeamNNL@f0f5b53:

Reader: one unreadable schema no longer fails the catalog. It errors only when no table could be read.
isSet: ASCII flag bytes such as 0 are read as text, with a test.

Skipped:

SQL Server datetime fraction: needs a per-engine shape rule I have not verified.
Stale cached catalog: needs a refresh path and a decision on what happens to results and selection.
Open stops a running search: looks intended, the maintainer's call.
Duplicated tables format: cosmetic.
Oracle date literal: touches the existing filter bar, out of scope here.

Checks: none run. SwiftLint fails here (sourcekitd missing) and there is no local Xcode build.

Cherry-pick: git fetch https://github.com/J2TeamNNL/TablePro review-fix/3737 && git cherry-pick f0f5b53b94ff410f2d7a54b72b2d380ae651d233

datlechin added 7 commits October 21, 2026 08:24

feat(search): find a value in every table of a database

de7e0f7

fix(search): offer search on hierarchical schemas, accept SET lists, …

7bb8b02

…add the strings

fix(filter): write Trino's case flag in the pattern, escape [ for SQL…

67ab952

… Server, use ANSI dates on Oracle

fix(filter): treat SQL Server TEXT as having no equality, dim Match C…

b5d1bd6

…ase where collation decides

fix(search): search only the columns an engine can compare, stop befo…

c24d494

…re the scan

docs(changelog): add the search and filter fragments for #3737

09fc1d8

test(search): read the opened tab's grid by its 1-based cell labels

66aaeb7

datlechin mentioned this pull request Oct 21, 2026

docs(features): document Search Database TableProApp/docs#92

Merged

datlechin enabled auto-merge (squash) October 21, 2026 03:12

datlechin added 3 commits October 21, 2026 11:00

Merge remote-tracking branch 'origin/main' into feat/3601-search-data…

5d6afaf

…base # Conflicts: # apple/TablePro/Core/Utilities/SQL/ColumnTypeSQLQuoting.swift # apple/TablePro/Resources/Localizable.xcstrings

Merge remote-tracking branch 'origin/main' into feat/3601-search-data…

984acf3

…base # Conflicts: # apple/TablePro/Views/Main/MainContentCoordinator.swift

Merge remote-tracking branch 'origin/main' into feat/3601-search-data…

5c56bd1

…base

datlechin mentioned this pull request Oct 21, 2026

perf(linux-sidebar): pick the sidebar's search rows off the GTK thread #3747

Merged

J2TeamNNL reviewed Oct 21, 2026

View reviewed changes

datlechin merged commit babb15c into main Oct 21, 2026
8 checks passed

datlechin deleted the feat/3601-search-database branch October 21, 2026 11:14

datlechin mentioned this pull request Oct 23, 2026

feat(blog): add the TablePro 0.83 beta post TableProApp/web#125

Closed

Navigation Menu

Repository navigation

feat(search): find a value in every table of a database - #3737

feat(search): find a value in every table of a database#3737
datlechin merged 10 commits into
mainfrom
feat/3601-search-database

datlechin commented Oct 21, 2026 •

edited

Loading

Uh oh!

J2TeamNNL left a comment

Uh oh!

J2TeamNNL Oct 21, 2026

Uh oh!

J2TeamNNL Oct 21, 2026

Uh oh!

J2TeamNNL Oct 21, 2026

Uh oh!

J2TeamNNL Oct 21, 2026

Uh oh!

J2TeamNNL Oct 21, 2026

Uh oh!

J2TeamNNL Oct 21, 2026

Uh oh!

J2TeamNNL Oct 21, 2026

Uh oh!

J2TeamNNL commented Oct 21, 2026

Uh oh!

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

datlechin commented Oct 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Test plan

Uh oh!

J2TeamNNL left a comment

Choose a reason for hiding this comment

Uh oh!

J2TeamNNL Oct 21, 2026

Choose a reason for hiding this comment

Uh oh!

J2TeamNNL Oct 21, 2026

Choose a reason for hiding this comment

Uh oh!

J2TeamNNL Oct 21, 2026

Choose a reason for hiding this comment

Uh oh!

J2TeamNNL Oct 21, 2026

Choose a reason for hiding this comment

Uh oh!

J2TeamNNL Oct 21, 2026

Choose a reason for hiding this comment

Uh oh!

J2TeamNNL Oct 21, 2026

Choose a reason for hiding this comment

Uh oh!

J2TeamNNL Oct 21, 2026

Choose a reason for hiding this comment

Uh oh!

J2TeamNNL commented Oct 21, 2026

Uh oh!

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

datlechin commented Oct 21, 2026 •

edited

Loading