fix(terminal): size rows to the visible viewport - #48
Merged
ZacharyZcR merged 1 commit intoAug 12, 2026
Merged
Conversation
TUI apps (Claude Code, Codex, vim, htop) draw their bottom input row at the pty's last row. The WebView was sized by marginBottom so it spans only the visible area, but xterm computed rows from #terminal's 100vh CSS height, which WKWebView reports stale after a frame resize. The pty told the shell too many rows, so TUIs painted their input row behind the keyboard bar. Measure the real visible height with onLayout, push it into the WebView (debounced to avoid resize storms), pin #terminal's height to it, then fit and re-send the pty resize. Re-apply on terminalReady and prefer the pinned height in nativeFit/resize over the stale 100vh. Co-Authored-By: Claude <noreply@anthropic.com>
This was referenced Aug 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
100vhThis extracts the viewport-sizing fix from #39 onto
dev-1.5.0. The original commit remains authored by Tink (goxofy). Touch scrolling is intentionally handled separately.Verification
npx tsc --noEmitnpm run format:checkgit diff --checkPartially supersedes #39.