Use Tcl_Size for all tcl functions returning sizes.#323
Closed
hzeller wants to merge 2 commits intoThe-OpenROAD-Project:masterfrom
Closed
Use Tcl_Size for all tcl functions returning sizes.#323hzeller wants to merge 2 commits intoThe-OpenROAD-Project:masterfrom
Tcl_Size for all tcl functions returning sizes.#323hzeller wants to merge 2 commits intoThe-OpenROAD-Project:masterfrom
Conversation
Contributor
Author
|
I don't know where the CI is failing |
This is the correct type and starting with Tcl9 it will actually result in compile errors if not used. Signed-off-by: Henner Zeller <h.zeller@acm.org>
hzeller
force-pushed
the
feature-20260328-tcl-size
branch
from
d9349a2 to
5fb3c28
Compare
In modern tcl, `trace variable` is now `trace add variable`,
and `"rw"` is spelled out as `{read write}`
There were backwards compatible forms in Tcl 8.x but got
removed in Tcl 9.
Signed-off-by: Henner Zeller <h.zeller@acm.org>
hzeller
force-pushed
the
feature-20260328-tcl-size
branch
from
5fb3c28 to
66ee2e2
Compare
Contributor
Author
|
The CI seems to be failing due to some docker container not loading ? @maliberty do you see what is going on ? Also, is this PR something for here, or should I send an upstream PR to parallaxsw ? |
Member
|
relaunched |
Contributor
Author
|
Converting to draft for now: let me first try to get it into upstream parallax as it will help avoid merge conflicts in the future. |
Contributor
Author
|
Closing. Landed this upstream parallaxsw/OpenSTA#414 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the correct type and starting with Tcl9 it will actually result in compile errors if not used.