Remove dead remove_constraints placeholder blocks from SDC tests#338
Closed
openroad-ci wants to merge 1 commit intoThe-OpenROAD-Project:masterfrom
Closed
Remove dead remove_constraints placeholder blocks from SDC tests#338openroad-ci wants to merge 1 commit intoThe-OpenROAD-Project:masterfrom
openroad-ci wants to merge 1 commit intoThe-OpenROAD-Project:masterfrom
Conversation
The remove_constraints API was permanently removed from Sta. Delete the commented-out calls, TODO comments, and "skipped" print statements instead of keeping placeholder blocks. Co-Authored-By: Claude <noreply@anthropic.com> Signed-off-by: Jaehyun Kim <jhkim@precisioninno.com>
Contributor
|
The changes in this PR are merged into #332 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
sta::remove_constraintscalls, TODO comments, and "skipped (API removed)" print statements fromsdc_exception_merge_priority.tclandsdc_filter_query.tcl.okgolden filesremove_constraintsAPI was permanently removed from Sta; placeholder blocks should be deleted, not keptRegression
6109/6109 tests pass (
ctest -j$(nproc))Related
Follow-up from 3-way code review of PR #42