Skip to content

Remove dead remove_constraints placeholder blocks from SDC tests #338

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
openroad-ci wants to merge 1 commit into from
Closed

Remove dead remove_constraints placeholder blocks from SDC tests #338

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions sdc/test/sdc_exception_merge_priority.ok
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1094,8 +1094,6 @@ Path Type: max
7.89 slack (MET)


--- remove_constraints ---
remove_constraints: skipped (API removed)
Startpoint: reg2 (rising edge-triggered flip-flop clocked by clk1)
Endpoint: out1 (output port clocked by clk1)
Path Group: grp1
Expand Down
7 changes: 0 additions & 7 deletions sdc/test/sdc_exception_merge_priority.tcl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,13 +115,6 @@ puts "--- exception override: false path then max_delay ---"
set_max_delay -from [get_ports in3] -to [get_ports out2] 5.0
report_checks

# remove_constraints (remove all SDC constraints)
puts "--- remove_constraints ---"
# TODO: sta::remove_constraints removed from Sta API
# sta::remove_constraints
# report_checks
puts "remove_constraints: skipped (API removed)"

# Re-add constraints for write_sdc
create_clock -name clk1 -period 10 [get_ports clk1]
create_clock -name clk2 -period 20 [get_ports clk2]
Expand Down
1 change: 0 additions & 1 deletion sdc/test/sdc_filter_query.ok
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,5 +29,4 @@ filter_insts ref_name =~ BUF*: 1
filter_pins direction == input: 1
filter_nets full_name =~ n*: 7
No differences found.
remove_constraints: skipped (API removed)
No differences found.
10 changes: 1 addition & 9 deletions sdc/test/sdc_filter_query.tcl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
# net_is_constrained, is_clock_src, is_clock, is_ideal_clock,
# clk_thru_tristate_enabled, set_clk_thru_tristate_enabled,
# find_clocks_matching, default_arrival_clock,
# pin_case_logic_value, pin_logic_value, remove_constraints
# pin_case_logic_value, pin_logic_value
source ../../test/helpers.tcl

read_liberty ../../test/nangate45/Nangate45_typ.lib
Expand Down Expand Up @@ -179,14 +179,6 @@ diff_files sdc_filter_query1.sdcok $sdc1
unset_case_analysis [get_ports in1]
unset_case_analysis [get_ports in2]

############################################################
# remove_constraints
############################################################
# TODO: sta::remove_constraints removed from Sta API
# sta::remove_constraints
# report_checks
puts "remove_constraints: skipped (API removed)"

############################################################
# Re-apply constraints for final write
############################################################
Expand Down