Skip to content

The sum of outcomes for rolling an N-sided dice K times. - #11463

Open
dipuk0506 wants to merge 52 commits into
TheAlgorithms:masterfrom
dipuk0506:master
Open

The sum of outcomes for rolling an N-sided dice K times.#11463
dipuk0506 wants to merge 52 commits into
TheAlgorithms:masterfrom
dipuk0506:master

Conversation

@dipuk0506

@dipuk0506 dipuk0506 commented Jun 15, 2024

Copy link
Copy Markdown

Describe your change:

  • Add an algorithm?

    The sum of outcomes for rolling an N-sided dice K times.

    This function returns a list. The last two elements are the
    range of probability distribution.
    The range is: 'k_time' to 'k_time*n_side'

    Other elements contain probabilities for getting a summation
    from 'k_time' to 'k_time*n_side'.

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms include at least one URL that points to Wikipedia or another similar explanation.
  • If this pull request resolves one or more open issues then the description above includes the issue number(s) with a closing keyword: "Fixes #ISSUE-NUMBER".

dipuk0506 and others added 30 commits June 11, 2024 07:19
@dipuk0506
Create Image_Classification_Example_MNIST_CNN.py
4fd289f 
Image Classification Example
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
29671f5 
for more information, see https://pre-commit.ci
@dipuk0506
Update and rename Image_Classification_Example_MNIST_CNN.py to image_…
4e3484a 
…classification_example_mnist_cnn.py
@dipuk0506
Update image_classification_example_mnist_cnn.py
7b70f64
@dipuk0506
Delete computer_vision/image_classification_example_mnist_cnn.py
a4b7330
@dipuk0506
Create probability_of_n_heads_in_m_tossing.py
158c1fe
@dipuk0506
Update probability_of_n_heads_in_m_tossing.py
d8b68ba
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
c49619c 
for more information, see https://pre-commit.ci
@dipuk0506
Update probability_of_n_heads_in_m_tossing.py
b62a774
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
707b446 
for more information, see https://pre-commit.ci
@dipuk0506
Update probability_of_n_heads_in_m_tossing.py
df400a7
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
929301c 
for more information, see https://pre-commit.ci
@dipuk0506
Update probability_of_n_heads_in_m_tossing.py
b84ac59
@dipuk0506
Update probability_of_n_heads_in_m_tossing.py
b79e0c1
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
205cb87 
for more information, see https://pre-commit.ci
@dipuk0506
Update probability_of_n_heads_in_m_tossing.py
c987949
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
366f1ff 
for more information, see https://pre-commit.ci
@dipuk0506
Update probability_of_n_heads_in_m_tossing.py
ac01ab0
@dipuk0506
Update and rename probability_of_n_heads_in_m_tossing.py to outcome_o…
e4129b9 
…f_rolling_n_sided_dice_k_time.py
@dipuk0506
Update outcome_of_rolling_n_sided_dice_k_time.py
00e2389
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
ce9e835 
for more information, see https://pre-commit.ci
@dipuk0506
Update and rename outcome_of_rolling_n_sided_dice_k_time.py to sum_of…
c7d9ea4 
…_outcomes_for_rolling_n_sided_dice_k_time.py
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
d8f511c 
for more information, see https://pre-commit.ci
@dipuk0506
Update sum_of_outcomes_for_rolling_n_sided_dice_k_time.py
fcf30bc
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
360ef80 
for more information, see https://pre-commit.ci
@dipuk0506
Update sum_of_outcomes_for_rolling_n_sided_dice_k_time.py
749499a
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
7bea0d9 
for more information, see https://pre-commit.ci
@dipuk0506
Update sum_of_outcomes_for_rolling_n_sided_dice_k_time.py
164a51d
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
b8cb3bc 
for more information, see https://pre-commit.ci
@dipuk0506
Update sum_of_outcomes_for_rolling_n_sided_dice_k_time.py
ccf5053
@algorithms-keeper algorithms-keeper Bot added tests are failing Do not merge until tests pass and removed tests are failing Do not merge until tests pass labels Jun 15, 2024
@dipuk0506

dipuk0506 commented Jun 16, 2024

Copy link
Copy Markdown
Author

Hi, If you have any confusion about the algorithm, you can email me at hmdkabir@connect.ust.hk and arrange a meeting.

@dipuk0506

dipuk0506 commented Jun 19, 2024

Copy link
Copy Markdown
Author

Please email me, if you are confused.

@dipuk0506

dipuk0506 commented Jun 19, 2024

Copy link
Copy Markdown
Author

There are two typos in comments. Everything else seems correct.

Lines 40 and 41 will be as follows:

The probability of getting 2 is 1/36.
The probability of getting 3 is 2/36.

@dipuk0506

dipuk0506 commented Jun 20, 2024

Copy link
Copy Markdown
Author

Please approve

@dipuk0506

dipuk0506 commented Jun 25, 2024

Copy link
Copy Markdown
Author

For theory visit the wiki page:
https://en.wikipedia.org/wiki/Convolution_of_probability_distributions

For more explanation of the theory please visit my GitHub repository:
https://github.com/dipuk0506/dice

Please correct 2 typos and merge.

@dipuk0506

dipuk0506 commented Jul 5, 2024

Copy link
Copy Markdown
Author

Please Merge the request.

@cclauss cclauss mentioned this pull request Sep 13, 2026
Open
@algorithms-keeper algorithms-keeper Bot added the awaiting reviews This PR is ready to be reviewed label Sep 14, 2026
cclauss
cclauss reviewed Sep 15, 2026
View reviewed changes
Comment thread maths/sum_of_outcomes_for_rolling_n_sided_dice_k_time.py
import numpy as np


def outcome_of_rolling_n_sided_dice_k_time(n_side: int, k_time: int) -> float:

@cclauss cclauss Sep 15, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CONTRIBUTING.md says that variable names should be self-documenting.

Suggested change
def outcome_of_rolling_n_sided_dice_k_time(n_side: int, k_time: int) -> float:
def outcome_of_rolling_n_sided_dice_k_time(number_of_sides: int, number_of_rolls: int) -> float:

@algorithms-keeper algorithms-keeper Bot added awaiting changes A maintainer has requested changes to this PR and removed awaiting reviews This PR is ready to be reviewed labels Sep 15, 2026
@algorithms-keeper algorithms-keeper Bot added awaiting reviews This PR is ready to be reviewed and removed awaiting changes A maintainer has requested changes to this PR labels Sep 15, 2026
@cclauss cclauss added awaiting changes A maintainer has requested changes to this PR and removed awaiting reviews This PR is ready to be reviewed labels Sep 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cclauss cclauss cclauss requested changes
+2 more reviewers
@imSanko imSanko imSanko approved these changes
@mindaugl mindaugl mindaugl approved these changes
Reviewers whose approvals may not affect merge requirements

Requested changes must be addressed to merge this pull request.

Assignees

No one assigned

Labels

awaiting changes A maintainer has requested changes to this PR

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@dipuk0506 @cclauss @imSanko @mindaugl